Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensured the Page cache identifier is read in the same way and checking and saving the cache identifier #38646

Open
wants to merge 4 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

digitalrisedorset
Copy link

@digitalrisedorset digitalrisedorset commented Apr 22, 2024

Ensured the Page cache identifier is read in the same way and checking and saving the cache identifier

The change consists using a new model that pulls the design + store cache parameters. This model is injected in both places that needs these cache information. This has meant a plugin was removed in favour of this model.

Description (*)

When the page gets loaded, the FPC checks if the page cache identifier is already saved in the cache. This reading checks the server environment variables (eg: PARAM_RUN_CODE).
When the page has been rendered, the page cache identifier is saved to prevent the same page to be reloaded the next loads the same version for it. The identifier was currently saved differently to the identifier created in the reading phase and that was breaking the cache

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Built-in FPC cache is broken in 2.4.7 for some configurations #38626

Manual testing scenarios (*)

Test 1: Backward compatibility - The FPC works

Setup the Magento store with no environment variable PARAM_RUN_CODE, PARAM_RUN_TYPE, ensure the Full page cache is enabled and set the developer mode active, load a page twice and verify the second load is cached by checking the header X-Magento-Cache-Debug

Test 2: Test the fault - The FPC works with environment variables

Setup the Magento store with some environment variables PARAM_RUN_CODE, PARAM_RUN_TYPE, ensure the Full page cache is enabled and set the developer mode active, load a page twice and verify the second load is cached by checking the header X-Magento-Cache-Debug

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented Apr 22, 2024

Hi @digitalrisedorset. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@engcom-Charlie engcom-Charlie added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Apr 23, 2024
@digitalrisedorset
Copy link
Author

@magento run all tests

@engcom-Bravo
Copy link
Contributor

Hi,

Internal team has started to work on it

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: pending review
Projects
Pull Requests Dashboard
  
Pending Review
Development

Successfully merging this pull request may close these issues.

Built-in FPC cache is broken in 2.4.7 for some configurations
3 participants