Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dom observer not calling all listeners (regression) #38623

Open
wants to merge 1 commit into
base: 2.4-develop
Choose a base branch
from
Open

Fix dom observer not calling all listeners (regression) #38623

wants to merge 1 commit into from
+1 −1

Conversation

thlassche
Copy link
Contributor

Description (*)

A change in dom-observer.js in 5b931fe changed the logic, making it only call the first listener instead of all listeners. This leads to unexpected behaviour

The return here now exits the loop early, which wasn't the case before, since it was inside a _ function before: 5b931fe#diff-844cfb7b272693bacaa64be3a0fd96a543cc145b478330777c39682cc15b5961R152

Fixed Issues (if relevant)

  1. Fixes Category description WYSIWYG is empty on non default storeview #38622

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Apr 16, 2024

Hi @thlassche. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Apr 16, 2024
@thlassche thlassche mentioned this pull request Apr 16, 2024
Open
5 tasks
@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Apr 16, 2024 •
edited

@thlassche wasn't it fixed in #38276 ?
Ah, looks like we had a similar fix in #38537

@ihor-sviziev ihor-sviziev added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Apr 16, 2024
@ihor-sviziev
Copy link
Contributor

@magento run all tests

@m2-community-project m2-community-project bot moved this from Pending Review to Ready for Testing in Pull Requests Dashboard Apr 16, 2024
@ihor-sviziev ihor-sviziev mentioned this pull request Apr 16, 2024
Merged
5 tasks
@engcom-Bravo engcom-Bravo self-assigned this Apr 16, 2024
@engcom-Bravo engcom-Bravo moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Apr 16, 2024
@engcom-Bravo
Copy link
Contributor

@magento run all tests

@engcom-Bravo
Copy link
Contributor

@magento give me test instance

@magento-deployment-service Magento Deployment Service
Copy link

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service Magento Deployment Service
Copy link

Hi @engcom-Bravo, here is your Magento Instance: https://16dd4518b17f0dfee16359646226dbfd.instances-prod.magento-community.engineering
Admin access: https://16dd4518b17f0dfee16359646226dbfd.instances-prod.magento-community.engineering/admin_9c6d
Login: 365088d2
Password: 6d2b5eb3900a

@engcom-Bravo
Copy link
Contributor

Hi @thlassche,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Steps to reproduce

  • Edit category in the backend on storeview level
  • Untick the box 'Use default value' next to the category description field WYSWYG editor
  • Enter a description in the WYSIWYG editor
  • Save

Before: ✖️ 

Screenshot 2024-04-17 at 09 56 03

After: ✔️  

Screenshot 2024-04-17 at 11 53 42 Screenshot 2024-04-17 at 11 54 20

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

@engcom-Bravo engcom-Bravo moved this from Testing in Progress to Extended Testing (optional) in Pull Requests Dashboard Apr 17, 2024
@sprankhub sprankhub mentioned this pull request Apr 30, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Bravo engcom-Bravo

Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: extended testing
Projects
Pull Requests Dashboard
  
Extended Testing (optional)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Category description WYSIWYG is empty on non default storeview
3 participants
@thlassche @ihor-sviziev @engcom-Bravo