Pricing Index runs without ever completing - Magento 2.3.1

[batmike]

Preconditions (*)

1. Magento 2.3.1
2. PHP 7.2
3. MySQL 5.7

Steps to reproduce (*)

1. Heavily configurable product based catalog - about 375,000 total products of which about 15,000 are configurable products and the remaining 350,000 are simple products links to the configurables.
2. Upon upgrading to version 2.3.1 from version 2.3.0, the pricing index (catalog_product_price) would not complete indexing and would run without ending (in my environment, I let it run out to about 50 hours before giving up)
3. After reverting the changes made in the following commits, pricing index was able to be rebuilt again:

• 47675cc
• 364ebfe
• 4350a2e

Expected result (*)

1. Pricing index should be able to be fully rebuilt and moved into the active price database table in a reasonable amount of time

Actual result (*)

1. Pricing index does not rebuild after our maximum test time of 45 hours.
2. With a 32 core, 120 GB RAM server, the pricing index was able to be rebuilt in approximately 3 minutes on the above catalog size configuration after the rollback of the noted commits to version 2.3.1.

[m2-assistant]

Hi @batmike. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@batmike do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

[batmike]

@magento-engcom-team give me 2.3.1 instance

[magento-engcom-team]

Hi @batmike. Thank you for your request. I'm working on Magento 2.3.1 instance for you

[magento-engcom-team]

Hi @batmike, here is your Magento instance.
Admin access: https://i-22516-2-3-1.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[batmike]

@magento-engcom-team

I have the instance but cannot confirm as I would need to run some kind of sample data loader to build out a similar configurable/simple product catalog like we have in production. I also have to way to run the indexer from the CLI.

If these are available to run in a test vanilla environment, I'd be happy to test and see if it still does a similar thing to what we experienced.

[orlangur]

@batmike this is just a bot :) Simply wow, thanks for such a fruitful investigation.

@kandy you should like this.

[batmike]

@orlangur - of course it is! Just trying to get used to talking more with the machines than people ahead of time.

[royandre]

We are experiencing the same issue in 2.3.1 (multi-site, +80k SKUs (around 15k configurable, with simples attached), with the price index taking like forever (7+ hours), though we actually managed to finish it, and thus have the product appear in the store.

We are trying to tune the batch size (https://devdocs.magento.com/guides/v2.3/extension-dev-guide/indexer-batch.html), which seems to might affect this, so recommend others experiencing this issue to also check the batching as mentioned in the above link.

[acampos1916]

@royandre we're in a similar situation and get a very slow price reindexing. We adjusted the batch size for configurable and default down to 1000 and the improvement is not great. What batching setup did you end up using?

Investigating the catalog_product_index_price_temp temporal table I can see that it gets populated by a query that is exponentially slower as more products are enabled in more store views or at least that's what I think.

2.3.1 EE, 60k SKUs, 7k configurables

[enl]

It looks like this guy ignores product's type when it creates batches and therefore each indexer walks through all the products: https://github.com/magento/magento2/blob/2.3-develop/app/code/Magento/Catalog/Model/Indexer/Product/Price/Action/Full.php#L275

[m2-assistant]

Hi @andimov. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.
  Details

  - Add the comment @magento give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.