Cannot add bundled products to cart if bundle has a special price

[justinharris1986]

Preconditions

1. Magento 2.2.8
2. PHP 7.1.27 (In our case - may or may not be a factor - we are running in php-fpm)
3. MariaDB 10.3.13-1.el7.centos (In our case - may or may not be a factor)
4. Bundle product with a special price attached

Steps to reproduce

1. Create 2 simple products
2. Create a bundle with the simple products, and add a Special Price from the advanced pricing page
3. Go to the front end, and add to cart

Expected result

1. Adds to cart successfully

Actual result (*)

1. PHP eats up to max_memory limit, and then dies, generating a 500 to the user
2. Navigate to home page, and then directly to the cart - fails with the same as 1, above.
3. note the minicart does not load.
4. Remove the special price from the back end
5. Cart now loads successfully

This issue did NOT manifest itself in 2.2.7.

[m2-assistant]

Hi @justinharris1986. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@justinharris1986 do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

[justinharris1986]

@magento-engcom-team give me 2.2-develop instance

[magento-engcom-team]

Hi @justinharris1986. Thank you for your request. I'm working on Magento 2.2-develop instance for you

[magento-engcom-team]

Hi @justinharris1986, here is your Magento instance.
Admin access: https://i-22095-2-2-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[justinharris1986]

@magento-engcom-team - Yes I was able to reproduce this in 2.2. Not sure if it matters or not, but i disabled "Dynamic Price" and manually set a price in the bundle.

2nd - with our theme, we get a 500, however, with the default Luma, it just sits there on "adding". I am presuming it will eventually time out. This was the add request after letting it sit for 3 minutes after clicking add to cart:

More screenshots to hopefully help:
Simple product 1 configs (nothing touched under advanced pricing here):

Simple product 2 configs (nothing touched under advanced pricing here):

Bundle config:

and the advanced config for the bundle, this is what breaks:

if you remove the 5% from there, and save the product, you can then add the product to the cart

[m2-assistant]

Hi @Jitheesh. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.
  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

[Jitheesh]

Issue replicated on 2.3 branch but looks like it is resolved on 2.3-develop branch.

This issue is because of a infinite loop while calculating special price of a bundled product.

Magento is looking for product Tier price and Special price for finding the final price of a product.
Check following functions to identify this infinite loop.

magento2/app/code/Magento/Bundle/Model/Product/Price.php

Lines 518 to 526 in fd2771b

	public function getTierPrice($qty, $product)
	{
	$allCustomersGroupId = $this->_groupManagement->getAllCustomersGroup()->getId();
	$prices = $product->getData('tier_price');
	if ($prices === null) {
	if ($attribute = $product->getResource()->getAttribute('tier_price')) {
	$attribute->getBackend()->afterLoad($product);
	$prices = $product->getData('tier_price');

magento2/app/code/Magento/Catalog/Model/Product/Attribute/Backend/GroupPrice/AbstractGroupPrice.php

Lines 305 to 314 in fd2771b

	public function afterLoad($object)
	{
	$data = $this->_getResource()->loadPriceData(
	$object->getData($this->getMetadataPool()->getMetadata(ProductInterface::class)->getLinkField()),
	$this->getWebsiteId($object->getStoreId())
	);
	$this->setPriceData($object, $data);
	return $this;
	}

magento2/app/code/Magento/Catalog/Model/Product/Attribute/Backend/GroupPrice/AbstractGroupPrice.php

Lines 339 to 352 in fd2771b

	public function setPriceData($object, $priceData)
	{
	$priceData = $this->modifyPriceData($object, $priceData);
	$websiteId = $this->getWebsiteId($object->getStoreId());
	if (!$object->getData('_edit_mode') && $websiteId) {
	$priceData = $this->preparePriceData($priceData, $object->getTypeId(), $websiteId);
	}
	$object->setData($this->getAttribute()->getName(), $priceData);
	$object->setOrigData($this->getAttribute()->getName(), $priceData);
	$valueChangedKey = $this->getAttribute()->getName() . '_changed';
	$object->setOrigData($valueChangedKey, 0);
	$object->setData($valueChangedKey, 0);

magento2/app/code/Magento/Catalog/Model/Product/Attribute/Backend/Tierprice.php

Lines 160 to 186 in 0c78690

	protected function modifyPriceData($object, $data)
	{
	/** @var \Magento\Catalog\Model\Product $object */
	$data = parent::modifyPriceData($object, $data);
	$price = $object->getPrice();
	$specialPrice = $object->getSpecialPrice();
	$specialPriceFromDate = $object->getSpecialFromDate();
	$specialPriceToDate = $object->getSpecialToDate();
	$today = time();
	if ($specialPrice && ($object->getPrice() > $object->getFinalPrice())) {
	if ($today >= strtotime($specialPriceFromDate) && $today <= strtotime($specialPriceToDate) ||
	$today >= strtotime($specialPriceFromDate) && $specialPriceToDate === null) {
	$price = $specialPrice;
	}
	}
	foreach ($data as $key => $tierPrice) {
	$percentageValue = $this->getPercentage($tierPrice);
	if ($percentageValue) {
	$data[$key]['price'] = $price * (1 - $percentageValue / 100);
	$data[$key]['website_price'] = $data[$key]['price'];
	}
	}
	return $data;
	}

[AaronONeill]

We're experiencing the same issue since upgrading a site from 2.2.7 to 2.2.8. We have also found that removing the Special Price (% value) from the bundled product and saving allows us to successfully navigate to the cart/checkout page. When this field has a value, the cart/checkout process is broken entirely.

I have done some digging based on the files @Jitheesh provided. What we can see is that the following behaviour:

vendor/magento/module-bundle/Model/Product/Price.php

We can see that its getting the Bundle options and getting the selection final total price which leads to calling the _applyTierPrice($product, $qty, $finalPrice) function in the same file noted above.

Locally, where I can recreate the issue I set a breakpoint on the "$tierPrice = $product->getTierPrice($qty);" line within this function and noted the results.

We can see that when the cart loads, it calls this _applyTierPrice() function which then calls the "getTierPrice()" function, in this instance its located in:

vendor/magento/module-catalog/Model/Product.php

This then returns the getTierPrice function based on whats returned from getPriceModel(). This then runs the getTierPrice() function in:

vendor/magento/module-bundle/Model/Product/Price.php

Following the trace along, it triggers the "$attribute->getBackend()->afterLoad($product);" call where $prices are null. The afterLoad() function in:

vendor/magento/module-catalog/Model/Product/Attribute/Backend/GroupPrice/AbstractGroupPrice.php

Does some further processing to return the final price which ends up calling the __applyTierPrice() function in

vendor/magento/module-bundle/Model/Product/Price.php

Which is where the process started. As this is where the process started and it is calling the exact same "__applyTierPrice()" function, it is going through the exact same files calling the exact same functions and inevitably ending up in an infinite loop.

See screenshot below for more clarity on the above.

[genyuk]

Same issue on Magento 2.2.8 CE, MariaDB, Nginx
After trying to add a bundle product to the cart - site will crash after a few minutes on "waiting ...." and the issue will remain for any other (even simple) products. Restarting server and clearing browser cache on the client does help until the next try with bundle product .

Removing Special price does not help in our case.

Any tip on how to patch it will be appreciated.

[comaxxdevelopment]

For our projects we fixed this bug as followed:

Make an override for vendor/magento/module-catalog/Model/Product/Attribute/Backend/Tierprice.php line 171. Change it from:

if ($specialPrice && ($object->getPrice() > $object->getFinalPrice())) {
to
if ($specialPrice && ($object->getPrice() > $specialPrice)) {

Tested using bundles containing customer group prices and special price and correct price is used.

If you want to be even more specific you could also change it to only be different for bundle products. To do so use :

$isBundleProduct = $object->getTypeId() === \Magento\Catalog\Model\Product\Type::TYPE_BUNDLE; if ( ( ! $isBundleProduct && $specialPrice && ($object->getPrice() > $object->getFinalPrice()) ) || ( $isBundleProduct && $specialPrice && ($object->getPrice() > $specialPrice) ) ) {

Not sure if this is the intended solution but this does work for us.

[gulshanchitransh]

I am working on this at #dmcdindia1