Can't Disable Advanced Reporting

[nfourteen]

Preconditions

1. Magento 2.2.2

Steps to reproduce

1. After a fresh install of version 2.2.2, a system message was received that Synchronization Failed with Magento Business Intelligence (I don't remember the exact message).
2. To prevent further synchronization error messages, go to Stores > Configuration > General > Advanced Reporting and change Advanced Reporting Service to Disable
3. Press Save Config

Expected result

1. The advanced reporting capabilities should be disabled.

Actual result

1. The following weird error message is received: Please select a vertical.
2. The advanced reporting capabilities revert back to being enabled.

Reason and Proposed Solutions

The error is thrown from Magento\Analytics\Model\Config\Backend\Vertical::beforeSave() method because I did not select an Industry under Industry Data. That defaults to --Please Select-- and is an empty value, so beforeSave() behaves as it should.

Since the Advanced Reporting needs an external account and service, it should default to Disable on new installs. However, if it was Magento's intention to have it enabled for all new installs, then 1) the logic should be changed so an empty value for the Industry can be provided when Advanced Reporting Service is set to Disable and Save Config is pressed or 2) a more detailed error message should be displayed so merchants understand that an Industry must be provided, even to Disable the Advanced Reporting Service.

[PieterCappelle]

Hi @nfourteen, could you create PR? Thanks!

[nfourteen]

Hi @PieterCappelle, I just submitted the pull request.

[magento-engcom-team]

@nfourteen, thank you for your report.
We've created internal ticket(s) MAGETWO-86006 to track progress on the issue.

[tony-sar]

Select Disable and also select Industry data and click on save it should save . I think vertical message relate to the industry data

[jzahedieh]

And even when you disable it the message shows in the dashboard, this is in really bad taste Magento, promoting 3rd party services on the homepage of the admin interface without being able to disable it!

All you need to do is add ifconfig="analytics/general/enabled" to vendor/magento/module-analytics/view/adminhtml/layout/adminhtml_dashboard_index.xml

[adamlavery]

Agree with the sentiment here. New features like this should be by default disabled.

[fwolfst]

Nobody is scared that this is a sign that the developers are in need (the waving flag on the sinking ship)? ;) But fully agree. Especially together with #12828 where this actually drives away users customers. Anyways, thanks for the PR @nfourteen

[gfxguru]

New features disabled by default. That's a joke right? This is another attempt to reach an audience. They've been doing it for years and I'm tired of it.