Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Community - Width & Height attribute - Pagebuilder image #767 #847

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

Community - Width & Height attribute - Pagebuilder image #767 #847

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
976ac7f
Width & Height attribute - Pagebuilder image #767
aj-prajapati Apr 13, 2023
de9e2e8
Merge branch 'develop' into develop
engcom-Hotel Jan 10, 2024
8813e2d
Merge branch 'develop' into develop
engcom-Hotel Feb 28, 2024
ee485e4
Merge branch 'develop' into develop
engcom-Hotel Mar 14, 2024
a8e1c1a
Merge branch 'develop' into develop
engcom-Hotel Mar 18, 2024
066b903
Fix static tests failures
glo24157 Mar 18, 2024
04b8d9d
Fix static tests failures
glo24157 Mar 19, 2024
e5d48dd
Fix static tests failures
engcom-Hotel Mar 19, 2024
c23ec79
Fix static test failures
engcom-Hotel Mar 19, 2024
f079ff9
Added module in metapackage
engcom-Hotel Apr 8, 2024
86d9a99
Merge branch 'develop' into develop
engcom-Hotel Apr 15, 2024
0ba0a8f
Removing dependency
engcom-Hotel Apr 15, 2024
1e948c8
Fix static tests failures
engcom-Hotel Apr 24, 2024
b1d2e7b
Merge branch 'develop' into develop
engcom-Bravo May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
39 changes: 39 additions & 0 deletions app/code/Magento/PageBuilderImageAttribute/Test/Mftf/Data/ImageData.xml
View file
Open in desktop
@@ -0,0 +1,39 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
-->

<entities xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:mftf:DataGenerator/etc/dataProfileSchema.xsd">
<!-- Image Width -->
<entity name="PageBuilderImageWidthProperty" type="pagebuilder_width_property">
<data key="name">Width</data>
<data key="section">general</data>
<data key="fieldName">image_attribute_width</data>
<data key="value">123</data>
</entity>
<!-- Image Height -->
<entity name="PageBuilderImageHeightProperty" type="pagebuilder_Height_property">
<data key="name">Height</data>
<data key="section">general</data>
<data key="fieldName">image_attribute_height</data>
<data key="value">123</data>
</entity>
<!-- Mobile Image Width -->
<entity name="PageBuilderMobileImageWidthProperty" type="pagebuilder_mobile_width_property">
<data key="name">Width</data>
<data key="section">general</data>
<data key="fieldName">mobile_image_attribute_width</data>
<data key="value">123</data>
</entity>
<!-- Mobile Image Height -->
<entity name="PageBuilderMobileImageHeightProperty" type="pagebuilder_mobile_Height_property">
<data key="name">Height</data>
<data key="section">general</data>
<data key="fieldName">mobile_image_attribute_height</data>
<data key="value">123</data>
</entity>
</entities>
13 changes: 13 additions & 0 deletions app/code/Magento/PageBuilderImageAttribute/etc/module.xml
View file
Open in desktop
@@ -0,0 +1,13 @@
<?xml version="1.0" ?>
<!--
/**
* Changes by: Ajay Prajapati
*/
-->
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
<module name="Magento_PageBuilderImageAttribute" setup_version="1.0.0">
<sequence>
<module name="Magento_PageBuilder" />
</sequence>
</module>
</config>
8 changes: 8 additions & 0 deletions app/code/Magento/PageBuilderImageAttribute/registration.php
View file
Open in desktop
@@ -0,0 +1,8 @@
<?php
/**
* Changes by: Ajay Prajapati
*/

use Magento\Framework\Component\ComponentRegistrar;

ComponentRegistrar::register(ComponentRegistrar::MODULE, 'Magento_PageBuilderImageAttribute', __DIR__);
56 changes: 56 additions & 0 deletions app/code/Magento/PageBuilderImageAttribute/view/adminhtml/pagebuilder/content_type/image.xml
View file
Open in desktop
@@ -0,0 +1,56 @@
<?xml version="1.0"?>
<!--
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
-->
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_PageBuilder:etc/content_type.xsd">
<type name="image"
label="Image"
component="Magento_PageBuilder/js/content-type"
preview_component="Magento_PageBuilder/js/content-type/image/preview"
form="pagebuilder_image_form"
menu_section="media"
icon="icon-pagebuilder-image"
sortOrder="1"
translate="label">
<children default_policy="deny"/>
<appearances>
<appearance default="true"
name="full-width"
preview_template="Magento_PageBuilder/content-type/image/full-width/preview"
master_template="Magento_PageBuilder/content-type/image/full-width/master"
reader="Magento_PageBuilder/js/master-format/read/configurable">
<elements>
<element name="desktop_image">
<style name="border" source="border_style" converter="Magento_PageBuilder/js/converter/style/border-style"/>
<style name="border_color" source="border_color"/>
<style name="border_width" source="border_width" converter="Magento_PageBuilder/js/converter/style/border-width"/>
<style name="border_radius" source="border_radius" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
<static_style source="max-width" value="100%"/>
<static_style source="height" value="auto"/>
<attribute name="image" source="src" converter="Magento_PageBuilder/js/converter/attribute/src" preview_converter="Magento_PageBuilder/js/converter/attribute/preview/src"/>
<attribute name="alt" source="alt"/>
<attribute name="title_attribute" source="title"/>
<attribute name="image_attribute_width" source="width"/>
<attribute name="image_attribute_height" source="height"/>
</element>
<element name="mobile_image">
<style name="border" source="border_style" converter="Magento_PageBuilder/js/converter/style/border-style"/>
<style name="border_color" source="border_color"/>
<style name="border_width" source="border_width" converter="Magento_PageBuilder/js/converter/style/border-width"/>
<style name="border_radius" source="border_radius" converter="Magento_PageBuilder/js/converter/style/remove-px"/>
<static_style source="max-width" value="100%"/>
<static_style source="height" value="auto"/>
<attribute name="mobile_image" source="src" converter="Magento_PageBuilder/js/converter/attribute/src" preview_converter="Magento_PageBuilder/js/converter/attribute/preview/src"/>
<attribute name="alt" source="alt"/>
<attribute name="title_attribute" source="title"/>
<attribute name="mobile_image_attribute_width" source="width"/>
<attribute name="mobile_image_attribute_height" source="height"/>
</element>
</elements>
</appearance>
</appearances>
</type>
</config>
67 changes: 67 additions & 0 deletions .../Magento/PageBuilderImageAttribute/view/adminhtml/ui_component/pagebuilder_image_form.xml
View file
Open in desktop
@@ -0,0 +1,67 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
-->
<form xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Ui:etc/ui_configuration.xsd" extends="pagebuilder_base_form">
<fieldset name="general" sortOrder="20">
<field name="image_attribute_width" formElement="input" sortOrder="10">
<settings>
<validation>
<rule name="validate-digits" xsi:type="boolean">true</rule>
</validation>
<dataType>number</dataType>
<label translate="true">Image Attribute Width</label>
<addAfter translate="true">px</addAfter>
<additionalClasses>
<class name="admin__field-small">true</class>
</additionalClasses>
<dataScope>image_attribute_width</dataScope>
</settings>
</field>
<field name="image_attribute_height" formElement="input" sortOrder="11">
<settings>
<validation>
<rule name="validate-digits" xsi:type="boolean">true</rule>
</validation>
<dataType>number</dataType>
<label translate="true">Image Attribute Height</label>
<addAfter translate="true">px</addAfter>
<additionalClasses>
<class name="admin__field-small">true</class>
</additionalClasses>
<dataScope>image_attribute_height</dataScope>
</settings>
</field>
<field name="mobile_image_attribute_width" formElement="input" sortOrder="12">
<settings>
<validation>
<rule name="validate-digits" xsi:type="boolean">true</rule>
</validation>
<dataType>number</dataType>
<label translate="true">Mobile Image Attribute Width</label>
<addAfter translate="true">px</addAfter>
<additionalClasses>
<class name="admin__field-small">true</class>
</additionalClasses>
<dataScope>mobile_image_attribute_width</dataScope>
</settings>
</field>
<field name="mobile_image_attribute_height" formElement="input" sortOrder="13">
<settings>
<validation>
<rule name="validate-digits" xsi:type="boolean">true</rule>
</validation>
<dataType>number</dataType>
<label translate="true">Mobile Image Attribute Height</label>
<addAfter translate="true">px</addAfter>
<additionalClasses>
<class name="admin__field-small">true</class>
</additionalClasses>
<dataScope>mobile_image_attribute_height</dataScope>
</settings>
</field>
</fieldset>
</form>