New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
magento/magento2-page-builder#842: Template Preview Images Incorrectly Saved to Media Directory #843
base: develop
Are you sure you want to change the base?
Conversation
…tory - Adding `use function` for `preg_replace`, `str_replace`, `strpos`, `strtolower`, `substr`, and `uniqid` - Adding Missing `DIRECTORY_SEPARATOR` - Adding Missing `@throws` - Fixing `@return` Type(s) - Making `phpcs:ignore` Less Generic
@magento run Integration Tests, Unit Tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues. |
Sorry to ping directly, are these test failures already known (not related to this PR)? 🙏🏻 |
@bluemwhitew Those failures are definitely not expected. Looking at the builds, branches being used, etc., I THINK the issue is that magento/magento2-page-builder/ is not synced with magento-commerce/magento2-page-builder/. Looks like the commits are 1 year behind so a LOT of stuff is missing (like php 8.2 compatibility & whatever else)... |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues. |
@bluemwhitew direct message me again if there are more problems (otherwise I might miss it) |
Description (*)
This fixes an issue where Page Builder would save its preview images into the top-level
media
directory, as opposed to within its designated.template-manager
subdirectory. It also contains some minor refactoring.Story
N/A
Bug
N/A
Task
N/A
Fixed Issues
Builds
N/A
Related Pull Requests
N/A
Manual Testing Scenarios (*)
.template-manager
directoryQuestions or Comments
Other minor improvements that can be made here include:
storePreviewImage
method by creating helper methods which handle image naming conventions, etc.str_replace('.jpg', '-thumb.jpg', ...)
so that other file formats (such as PNG) can be used, particularly via data patches.Checklist