New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore styles which no longer apply #804
base: develop
Are you sure you want to change the base?
Conversation
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@fredden - can you pull develop branch into your fork's branch and fix a failing static test? After that we should be good to merge this PR! |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Functional Tests B2B |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Functional Tests B2B |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run all tests |
@magento create issue |
Description
When PageBuilder initialises, it moves styles from a <style> tag into
data-{viewport}-styles
attributes. If there are CSS selectors that do not match any elements, an error is thrown:This pull request fixes this bug.
Manual testing scenarios
<span>Sample text</span><style>#not-found { color: red; }</style>
)Checklist
Resolved issues: