Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix container width for description inside the catalog product view #802

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

PierW
Copy link
Member

@PierW PierW commented Feb 20, 2022

Description (*)

When I insert the description of the product I have this problem:

Schermata 2022-02-19 alle 20 35 38

It's not aligned

FIX:
Schermata 2022-02-19 alle 20 39 30

Schermata 2022-02-19 alle 20 40 58

Schermata 2022-02-19 alle 20 37 09

The text should be aligned

Story

Bug

  • #801 fix the container for description inserted with page builder inside catalog product view
  • #35123 fix the container for description inserted with page builder inside catalog product view

Task

Fixed Issues (if relevant)

  1. magento/magento2-page-builder#<issue_number>: Issue title

Builds

Related Pull Requests

Manual testing scenarios (*)

  1. Magento 2.4.3-p1
  2. Module Page Builder Enabled (Default)
  3. Design Page - Template Product full width (Default with page builder enabled)
  4. Enter to the backoffice
  5. Create a Product and insert a description with page builder inside a row and 1 column
  6. Save

Questions or comments

Checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@sdzhepa sdzhepa added the Priority: P3 Priority: P3 label May 5, 2022
@paras89
Copy link
Contributor

paras89 commented Oct 12, 2022

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Hotel
Copy link
Collaborator

@magento run all tests

@engcom-Hotel engcom-Hotel self-requested a review January 3, 2024 05:57
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

@engcom-Hotel
Copy link
Collaborator

@magento run Static Tests, Unit Tests, WebAPI Tests

Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

Copy link
Collaborator

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @PierW,

Please merge this PR branch with the latest develop branch, after that we can pick this PR for review.

Thanks

@engcom-Hotel
Copy link
Collaborator

@magento run all tests

Copy link
Collaborator

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Changes seems good to me, hence approving this PR.

@m2-community-project m2-community-project bot moved this from Ready for Review to Reviewer Approved in Pull Request Progress Feb 28, 2024
@engcom-Bravo
Copy link
Collaborator

@magento give me 2.4-develop test instance

Copy link

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

Copy link

Hi @engcom-Bravo, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@engcom-Bravo
Copy link
Collaborator

@magento give me test instance

Copy link

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

Copy link

@engcom-Bravo
Copy link
Collaborator

@magento run all tests

@engcom-Bravo
Copy link
Collaborator

Hi @PierW,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Manual testing scenario:

  • Module Page Builder Enabled (Default)
  • Design Page - Template Product full width (Default with page builder enabled)
  • Enter to the backoffice
  • Create a Product and insert a description with page builder inside a row and 1 column
  • Save

Before: ✖️ 

Screenshot from 2024-02-29 13-19-23

After: ✔️  

Screenshot from 2024-02-29 13-48-27

Thanks.

@engcom-Hotel
Copy link
Collaborator

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, Performance Acceptance Tests, Static Tests, Unit Tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Pull Request Progress
  
Reviewer Approved
Development

Successfully merging this pull request may close these issues.

None yet

5 participants