Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

less strict string matching in magento-vars.php #475

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

less strict string matching in magento-vars.php #475

wants to merge 5 commits into from

Conversation

taoufiqaitali
Copy link
Member

this changes fix issue #446 to allow writing less strict strings to check domains and sub domains

Description

Fixed Issues (if relevant)

  1. less strict string matching in magento-vars.php #446: less strict string matching in magento-vars.php

Contribution checklist

  • [ 1] Pull request has a meaningful description of its purpose
  • [ 1] All commits are accompanied by meaningful commit messages

@NadiyaS
Copy link
Contributor

NadiyaS commented May 26, 2020

Hi @taoufiqaitali ,
thank you for your contribution.
In the discussion with @joeshelton-wagento in #446 we talk about moving the whole code to the comments to let people know that it is not the only function they may use and will be more clear that they may modify it for their needs.
So, I would suggest to comment out this function.

@NadiyaS
Copy link
Contributor

NadiyaS commented Jun 24, 2020

Hi @taoufiqaitali,
Will you be able to change your PR using suggested changed I wrote in previous comment?

@taoufiqaitali
Copy link
Member Author

Hi @NadiyaS
I just seen the comment
Ok i will change it

@taoufiqaitali
Copy link
Member Author

@NadiyaS ok i added it as comment so people can choice what method to use

@BaDos
Copy link
Contributor

BaDos commented Jun 29, 2022

The internal task MCLOUD-8939 was created.

@BaDos BaDos removed their assignment Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants