Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Battlefield layout to stack tokens like lands #12242

Merged
merged 5 commits into from
May 14, 2024

Conversation

grimreap124
Copy link
Contributor

@grimreap124 grimreap124 commented May 14, 2024

Closes #8205, part of #7262

Tokes will now be stack the same as lands.
Create tokens with summoning sickness won't be stacked on the same token without summoning sickness and will remain in different piles until the board state is updated.
Tokes with counters and attached cards will be in their own stacks.

Summoning stick tokens not stacking
image
The turn after the tokens lose summoning sickness
image

Larger board state with different tokens
image

Tokens with +1/+1 counters being split
image

Sorry about all the changes my formatter changed the file a lot.

@JayDi85
Copy link
Member

JayDi85 commented May 14, 2024

Do not stack creature tokens -- it has bad UX with attacking/blocking/targeting for a user (small clickable zones, hidden stats, etc - see here more details). Must stack non-creature tokens like Food.

All other things and changes looks fine (if it's hard to revert long lines auto-formatting then that's ok to keep it in PR).

@JayDi85
Copy link
Member

JayDi85 commented May 14, 2024

As alternative solution for creature tokens -- it can additionally check power/toughness of firstPanelPerm.getOriginalPermanent() -- maybe it will be good.

Or code like firstPanelPerm.getOriginalPermanent().getOriginalPower().getBaseValue() or getModifiedBaseValue() or getValue() -- it must be better in use cases with dynamic boost effects (e.g. boost on attacking).

P.S. If you add counters size instead counters empty check then it can stack tokens with same counters -- maybe useful for some use cases in theory.

I thought there might be a reason for not stacking creature tokens, I would like to look at possible only stacking to 3 and giving more space so it easier to attack/defend. Not I'm aware of it I'll play around with it later
@grimreap124
Copy link
Contributor Author

I think if we aren't stacking creatures we don't really need to worry about counters. I have removed stacking creature tokens but might look into it later with a smaller stack count and more spacing to help with the small clickable zones or highlighting the card the mouse is over.

@JayDi85
Copy link
Member

JayDi85 commented May 14, 2024

It's will be hard to change card sizes/positions for a specific cards only (specific stack). So I recommends to split creature tokens by additional conditionals like P/T compare (see comment above)

@grimreap124
Copy link
Contributor Author

That make sense then you don't care what one you're blocking because they're all the same size. I'll let this release and create a new pull request with the other changes so I can do some more testing. Do you know how to cheat in tokens to test?

@JayDi85
Copy link
Member

JayDi85 commented May 14, 2024

Tokens:

token:Human:TreasureToken:1
token:Human:ZombieArmyToken:2

Loyalty counters for planeswalker

loyalty:Human:Karn Liberated:20

@JayDi85 JayDi85 merged commit 7e7287e into magefree:master May 14, 2024
3 checks passed
@grimreap124 grimreap124 deleted the stack-tokens branch May 14, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It would be nice if artifact/enchantment tokens stacked in a similar way to lands
2 participants