Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOT] Implementing Slicer, Hired Muscle #12241

Merged
merged 5 commits into from
May 21, 2024

Conversation

grimreap124
Copy link
Contributor

Added Slicer, Hired Muscle

@github-actions github-actions bot added the cards label May 12, 2024
@JayDi85
Copy link
Member

JayDi85 commented May 12, 2024

[[Slicer, Hired Muscle]]

Copy link

Slicer, Hired Muscle // Slicer, High-Speed Antagonist - (Gatherer) (Scryfall) (EDHREC)

{4}{R}
Legendary Artifact Creature — Robot
3/4
More Than Meets the Eye {2}{R} (You may cast this card converted for {2}{R}.)
Double strike, haste
At the beginning of each opponent's upkeep, you may have that player gain control of Slicer until end of turn. If you do, untap Slicer, goad it, and it can't be sacrificed this turn. If you don't, convert it.
🔄
Legendary Artifact — Vehicle
3/2
Living metal (As long as it's your turn, this Vehicle is also a creature.)
First strike, haste
Whenever Slicer deals combat damage to a player, convert it at end of combat.

@JayDi85
Copy link
Member

JayDi85 commented May 12, 2024

[[Wake Thrasher]]

Copy link

Wake Thrasher - (Gatherer) (Scryfall) (EDHREC)

{2}{U}
Creature — Merfolk Soldier
1/1
Whenever a permanent you control becomes untapped, Wake Thrasher gets +1/+1 until end of turn.

@grimreap124
Copy link
Contributor Author

Moved the gain control to the top, hopefully that was what you were looking for.

@grimreap124
Copy link
Contributor Author

I just tested the change with Wake Thrasher and it doesn't work. I'll try and iron out the card

Now will untap correctly applying untap effects
@JayDi85
Copy link
Member

JayDi85 commented May 12, 2024

VerifyTest failed on wrong color:

Error: (colors) != [R] for BOT - Slicer, High-Speed Antagonist - 6

@grimreap124
Copy link
Contributor Author

VerifyTest failed on wrong color:

Error: (colors) != [R] for BOT - Slicer, High-Speed Antagonist - 6

Where do you get that error I can't find anything useful when I run mvn test -B -X
I have a fix now but am running the test

@Susucre
Copy link
Contributor

Susucre commented May 12, 2024

You can look at the failed Travis build on github. Log is long, usually searching for 'error' find the relevant parts.

For maven no idea. I personally start it from IntelliJ.

@grimreap124
Copy link
Contributor Author

Thanks I found the error @JayDi85 mentioned, I can't find it in my local failing build though.

@JayDi85
Copy link
Member

JayDi85 commented May 12, 2024

Verify tests store in Mage.Verify folder, not Mage.Tests:

  • \Mage.Verify\src\test\java\mage\verify\VerifyCardDataTest.java

You can run single test or class by command line, see example in https://github.com/magefree/mage/wiki/Development-Testing-Tools#unit-tests-from-command-line

How to view travis logs (search for "error" or start looking from the end of the logs):
1:
shot_240512_155421

2:
shot_240512_155432

3:
shot_240512_155447

4:
shot_240512_155536

@grimreap124
Copy link
Contributor Author

Just needed to set the colour. Thanks for the help, I'll try and figure out where the error shows up in my local build.

@xenohedron xenohedron merged commit 2134535 into magefree:master May 21, 2024
15 checks passed
@xenohedron
Copy link
Contributor

thanks for the contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants