[WHO] Implement Weeping Angel #12236
Conversation
…een shuffled before its damage step
| } | ||
|
|
||
| // Based on PhyrexianVindicatorEffect | ||
| class WeepingAngelDamageEffect extends ReplacementEffectImpl { |
There was a problem hiding this comment.
This ideally ought to extend PreventionEffectImpl instead.
(I don't like the code you referenced... there's actually a lot of refactoring cleanup that ought to be done on damage prevention but that would require writing a lot of thorough tests.)
| @Override | ||
| public boolean replaceEvent(GameEvent event, Ability source, Game game) { | ||
| game.preventDamage(event, source, game, Integer.MAX_VALUE); | ||
| Card card = game.getCard(event.getTargetId()); |
There was a problem hiding this comment.
I'm pretty sure you should be getting Permanent, not Card, since it's on the battlefield.
There was a problem hiding this comment.
shuffleCardsToLibrary takes a Card (or Cards)--is this about making sure its also a permanent before shuffling it away?
There was a problem hiding this comment.
Permanent extends Card so no issue with that method signature. It's about instanceof checks in zone handling, to perform necessary battlefield-related cleanup.
see #10226 (comment) for example, it can cause phantom image of permanent on the battlefield
#10653