support until your next turn delayed trigger as shared class with proper Duration

[Susucre]

This makes DelayedTriggeredAbility with Duration.UntilYourNextTurn function as expected. (Before they would never expire).

A new shared class UntilYourNextTurnDelayedTriggeredAbility has been added to make it easy to set up in cards' code. Similarly to ConditionalInterveningIfTriggeredAbility, it is a meta-trigger class that contains an inner trigger (hence the many Overriden methods).

Once this is merged, cards in this search could be rewritten using the new class.

Related to #2078 (Tamiyo still need to be reworked, but wanted to mention it)
Close #11634

[Susucre]

When exactly this should be called in Turn::play can be slightly changed if anyone got a stronger opinion.
It should be after the turn's skipping logic is done, but before the first Phase start. In beginTurn seemed like a reasonable choice.

[JayDi85]

It's fine to call it here. But make sure it will support leaving players too:

800.4m. When a player leaves the game, any continuous effects with durations that last until that player's next turn or until a specific point in that turn will last until that turn would have begun. They neither expire immediately nor last indefinitely.

Looks like current code will be never called for leaved player and will keep trigger forever in game state. If it's true then player.hasReachedNextTurnAfterLeaving() will help with it:

[Susucre]

Thanks I did miss that.
I'll make test for it, and fix it asap.

[Susucre]

So after testing, the DelayedTriggers get cleared once the player leave/concede.
Which is incorrect, but less annoying, as the trigger expires just not at the right time.

By the way, If there are delayed triggers of a left player to stack, who decides stacking order? I need to read more on that in the CR.

[Susucre]

800.4d. If an object that would be owned by a player who has left the game would be created in any zone, it isn't created. If a triggered ability that would be controlled by a player who has left the game would be put onto the stack, it isn't put on the stack.

So triggers (which delayed triggers are) for leaving player don't trigger. So current no trigger after player left is correct behavior. I'll add proper cleanup though to not keep DelayedTriggerAbility the whole game.

[JayDi85]

Looks like it was unfinished -- you miss effect duration migrate to new logic too, not delayed only:

[Susucre]

Looks like it was unfinished -- you miss effect duration migrate to new logic too, not delayed only:

This is a way bigger scope, and need careful consideration to apply continuous effects during new turn logic to reapply continuous effects after the removal of the UntilYourNextTurn ones.