generalize batch event creation #12213
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Susucre
commented
May 2, 2024
Mage/src/main/java/mage/game/events/DamagedBatchCouldHaveFiredEvent.java
Outdated
Show resolved
Hide resolved
This should simplify adding new batch events in the future.
Susucre
force-pushed
the
genericize-add-batch-event
branch
from
699659e
to
0d3fcb3
Compare
JayDi85
reviewed
May 2, 2024
| @@ -42,6 +42,8 @@ | |||
| import org.apache.log4j.Logger; | |||
|
|
|||
| import java.io.Serializable; | |||
| import java.lang.reflect.Constructor; | |||
There was a problem hiding this comment.
Do not use reflect code in game engine (outside of tests and plugins/class loaders). Use interfaces and basic classes instead (GameEvent classes allow to do it).
There was a problem hiding this comment.
Well you have to explain how to do that.
I can't make an abstract static method in an interface and/or abstract class that would get Overriden by the inheritors.
There was a problem hiding this comment.
I agree that it is best to avoid reflection if possible, though I will note that Watcher class (core game engine) does use reflection already.
(Haven't yet thought about how to make this work with parameterized types without reflection.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generic method is a little more complex, as the batch event constructor is found and used by reflection.
But the individual addSimultaneousBatch methods are now simpler to comprehend, and new ones will be easier to make.