Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[M3C] Implement Planar Nexus and inroduce AllNonbasicLandTypes status (WIP) #12203

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

theelk801
Copy link
Contributor

Gonna have to do a few things to make this work, luckily we have precedent from how changeling is implemented. Probably gonna do [[Nearby Planet]] too.

@github-actions github-actions bot added the cards label Apr 30, 2024
@theelk801 theelk801 marked this pull request as draft April 30, 2024 16:51
@theelk801
Copy link
Contributor Author

ok still need to add tests and the actual card itself, gonna wait for previews to update

Copy link

Nearby Planet - (Gatherer) (Scryfall) (EDHREC)

Land
Rangeling (This card is every land type, including Plains, Island, Swamp, Mountain, Forest, Desert, Gate, Lair, Locus, and all those Urza's ones.)
Nearby Planet enters the battlefield tapped.
When Nearby Planet enters the battlefield, sacrifice it unless you pay {1}.

@JayDi85
Copy link
Member

JayDi85 commented Apr 30, 2024

There are many code with AllCreatureTypes usages, make sure it compatible with new field too:

shot_240430_211651

There are also code like that:
shot_240430_211947

I think there are must be many different places (abilities/effects) that require additional code to support it. Usage of AllCreatureTypes can hint to find possible use cases for land types.

@theelk801
Copy link
Contributor Author

yeah I caught a lot of them but I'll take another look to make sure I got them all

@jeffwadsworth
Copy link
Contributor

FYI: Dependency checks.

@JayDi85 JayDi85 changed the title [M3C] Implement Planar Nexus (WIP) [M3C] Implement Planar Nexus and inroduce AllNonbasicLandTypes status (WIP) May 2, 2024
@github-actions github-actions bot added the tests label May 22, 2024
@theelk801
Copy link
Contributor Author

need to add a few more tests but I think this is pretty close to ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants