Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hints for continuous effects #12166

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

alexander-novo
Copy link
Contributor

@alexander-novo alexander-novo commented Apr 21, 2024

There are a bunch of continuous effects that last for a while but aren't produced by static abilities, so they can be quite difficult to keep track of - especially when they are applied randomly. I've added the ability for continuous effects to add hints to permanents, and I've adjusted hints and log messages for a variety of confusing continuous effects.

I think there are potentially a lot more continuous effects that could benefit from this kind of hint, as well as more work on making the system more robust (perhaps continuous effects can add hints to more objects than just permanents? Also maybe they can add icons to permanents like combat restrictions do - then combat restrictions could be folded into this new system). Let me know what you think, and I'll add it.

Fixes #12156
Resolves #12200

@alexander-novo
Copy link
Contributor Author

alexander-novo commented Apr 21, 2024

Oh I took a few pictures of what some of them look like as well. These are from [[Impulsive Maneuvers]]:

image
image

And this is from [[Bria, Riptide Rogue]]:

image

Note: I've since replaced "this creature" in these hints with {this}, so it should read better.

Copy link

Impulsive Maneuvers - (Gatherer) (Scryfall) (EDHREC)

{2}{R}{R}
Enchantment
Whenever a creature attacks, flip a coin. If you win the flip, the next time that creature would deal combat damage this turn, it deals double that damage instead. If you lose the flip, the next time that creature would deal combat damage this turn, prevent that damage.

Unable to retrieve information for "Bria, Splitter of Seconds"

@alexander-novo
Copy link
Contributor Author

[[Bria, Riptide Rogue]]

Copy link

Bria, Riptide Rogue - (Gatherer) (Scryfall) (EDHREC)

{2}{U}{R}
Legendary Creature — Otter Rogue
3/3
Prowess (Whenever you cast a noncreature spell, this creature gets +1/+1 until end of turn.)
Other creatures you control have prowess. (If a creature has multiple instances of prowess, each triggers separately.)
Whenever you cast a noncreature spell, target creature you control can't be blocked this turn.

Changed function name to getAffectedHints
Made it return a List<Hint> instead of String
@alexander-novo
Copy link
Contributor Author

I'm up to date with current feedback. The test failures are verify failures from mtgJson stuff unfortunately.

@alexander-novo
Copy link
Contributor Author

alexander-novo commented May 2, 2024

Added a hint for exert and other effects which use DontUntapInControllersNextUntapStepTargetEffect

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants