-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hints for continuous effects #12166
base: master
Are you sure you want to change the base?
Conversation
Impulsive Maneuvers - (Gatherer) (Scryfall) (EDHREC)
Unable to retrieve information for "Bria, Splitter of Seconds" |
[[Bria, Riptide Rogue]] |
Bria, Riptide Rogue - (Gatherer) (Scryfall) (EDHREC)
|
Mage/src/main/java/mage/abilities/effects/common/combat/CantBeBlockedByAllTargetEffect.java
Show resolved
Hide resolved
Mage/src/main/java/mage/abilities/effects/ContinuousEffectsList.java
Outdated
Show resolved
Hide resolved
Mage/src/main/java/mage/abilities/effects/ContinuousEffectImpl.java
Outdated
Show resolved
Hide resolved
Mage/src/main/java/mage/abilities/effects/common/PreventDamageByTargetEffect.java
Outdated
Show resolved
Hide resolved
Changed function name to getAffectedHints Made it return a List<Hint> instead of String
I'm up to date with current feedback. The test failures are verify failures from mtgJson stuff unfortunately. |
There are a bunch of continuous effects that last for a while but aren't produced by static abilities, so they can be quite difficult to keep track of - especially when they are applied randomly. I've added the ability for continuous effects to add hints to permanents, and I've adjusted hints and log messages for a variety of confusing continuous effects.
I think there are potentially a lot more continuous effects that could benefit from this kind of hint, as well as more work on making the system more robust (perhaps continuous effects can add hints to more objects than just permanents? Also maybe they can add icons to permanents like combat restrictions do - then combat restrictions could be folded into this new system). Let me know what you think, and I'll add it.
Fixes #12156
Resolves #12200