engine.remove calls destroy too and the callback is now optional #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fs.unlink(torrentPath, function (err) { | ||
| if (err) return cb(err) | ||
| if (err && typeof cb === 'function') return cb(err) |
There was a problem hiding this comment.
If cb is undefined, is it worth continuing? Maybe just initialize cb to a default value? E.g. cb = cb || noop;
|
Ops you're right, I haven't thought to use an empty function |
|
This is related to the #98 too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #143
Now the callback is optional and engine.remove() calls automatically engine.destroy.
@mafintosh Sorry for the late fix but the college is destroying me (just to stay on topic), I'm used to use useless semicolon when I call function, but I respected your style here :)