Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gamma/Brightness filter #67

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

accraze
Copy link

@accraze accraze commented Dec 13, 2015

This PR is in reference to #8 video effects using css filters.

Two new things added:
  • Settings control/popup for video playback (this only appears when a video is playing)
  • Brightness filter for video (inside Settings popup)

gamma/brightness css filter has been added for videos. when a video plays a new settings control appears on the right hand side. this new popupcontains a range input that changes the video's brightness.
@max-mapper
Copy link
Collaborator

nice!

screen shot 2015-12-14 at 11 14 30 am

screenshot was hard to get so its half faded out

the font size in the settings menu looks a little big compared to the rest of the fonts, but otherwise i'm +1. lays some nice groundwork for other settings

@mafintosh
Copy link
Owner

i agree with @maxogden on the font. looking good otherwise!

@zeke
Copy link

zeke commented Dec 14, 2015

What are you watching, @maxogden?

@max-mapper
Copy link
Collaborator

iron chef america thanksgiving battle

@zeke
Copy link

zeke commented Dec 14, 2015

lol

@freeall
Copy link
Collaborator

freeall commented Dec 14, 2015

@maxogden not sure if it helps you in this case, but hitting space when taking a screenshot on osx selects the current window so you don't have to drag.

@accraze
Copy link
Author

accraze commented Dec 17, 2015

Thanks for the feedback guys! I resized the label down to 15px
... let me know if you think it should be a different size..

screenshot_converted

@mafintosh
Copy link
Owner

@accraze label size looks good now. i wonder if we could use the same slider as we use for volume control to have consistent ui across the app

@bmathews
Copy link
Collaborator

@mafintosh Just a heads up, I've been doing some experiments with refactoring and separating out the UI from the rest of the player/server code. It'll be another week or two until it's all finished though.

@mafintosh
Copy link
Owner

@bmathews oh sweet!

@accraze
Copy link
Author

accraze commented Dec 27, 2015

@mafintosh added the same slider to the brightness filter... lemme know if anything else needs changing
slider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants