Added second-order synergy functions for 4D PID #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added functions to C++ code, added python wrapper and pylinker.
Changed line 806 to fix error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some basic code to calculate the second order synergy atoms for 4-dimensional PID in a similar fashion to existing function for 'top' synergy of 4D PID.
Some of the function added is redundant with existing synergy function, meaning that if you were to compute the top synergy and second order synergies at once, you would be repeating some of the same calculations.
Would be great to have an all-encompassing PID function in C++ that calculates all 18 atoms of the 4-dimensional PID in the same function to reduce this redundancy. This would be a lot quicker than using each function separately for each atom.