Remove non-interior mutability in Foundation types #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
added
enhancement
madsmtm
force-pushed
the
non-mut
branch
2 times, most recently
from
b6563b7
to
a0454fb
Compare
madsmtm
force-pushed
the
rework-cargo-features
branch
5 times, most recently
from
3d26587
to
0ee1323
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #563.
I've run the new
mut_while_iterfuzz target for using AFL++ ~8 hours with 8 parallell processes, and using libFuzzer for ~7 hours with 6 parallell processes, to test whether Foundation's mutation detection is precise enough to catch all errors, such that we can declare it sound.A concrete place where this will be useful is Winit, which stores a
RefCell<Id<NSMutableAttributedString>>inside of a subclass ofNSViewto track marked text, but theRefCellhere should be completely unnecessary.