Add the CoreAudioTypes framework
#467
Conversation
I think it's best to put it in
The reason is that the anonymous enum ends up having a different type from the real enum. I think the general fix would just be to always cast when defining enum constants. I've just sorta assigned it as "part of #310" for now.
Yeah, the bindings are currently using the SDK from Xcode 14.2. I can update it to Xcode 14.3.1, but that requires me to do a 7GB download on a metered connection (I'm outside my home country currently), so I've been reluctant to do so. I'll do it at the start of August in any case, but if it's bothering you a lot, I can do it now.
You've done great so far, thank you! |
I did actually contemplate this one, though when I tried it I ran into issues when we special-case
The odd thing is that in theory I am using the 14.2 SDK, as I noted on my other PR - there I just didn't commit any of the |
Ah, then I think the issue is that you're using a newer The reason I'm not staying up to date here is that my Mac is from 2013, and not new enough to run the latest Xcode versions. I'll be buying a new one once I get home too, but it probably makes sense to merge that commit so that others who's using the latest Xcode (@simlay?) won't have this problem. |
Ahhhhhh, that makes sense! If we kept it, would it then be annoying for those that don't have the newer version? |
I suspect that's only me, but I guess we could also add a hack for doing the propagation ourselves? |
That could work, to be fair, though it depends how worth it it is likely to be versus how soon you'd be updating anyway, I guess |
|
Yeah. Though actually, I think our CI currently uses the clang from Xcode 14.2, so we'd probably have to either bump or support that too? So maybe it actually does make sense to add this hack, if not only to set some kind of precedent for how easy we make it to contribute to |
|
Ah yeah, that's a good point, and I'm definitely in favour of making things easier for people if possible |
|
@madsmtm cheers for the update of xcide etc - that should definitely make things easier! Apologies, I'd not (intentionally) abandoned these PRs, I'd just been relatively busy recently - should be able to bring them at least up to date at some point this week though |
|
No problem, I've been busy with other stuff myself |
This PR adds support for the
CoreAudioTypesframework, as an initial, (somewhat) simple start to the road of eventually addingAVFoundation.As simple and small a library as it is (almost exclusively type/constant definitions and header-only, not even any linking), it did throw a couple of curveballs at me:
u32into the generated code so it's completely silent to theicratelibrary itself. I'm not 100% convinced I've done this in the best way, so I'm very much open to discussion here!With regards to the generated code, I appear to have added a large number of
deprecatedattributes - I'm not sure if this is some issue with my SDK setup or whether the submodule just hasn't been updated since some relevant change! Happy to look into that if needed.More than happy for discussions on any decisions I've made in here, given I've not added anything here before!