Weather Widget #179
Open
Weather Widget #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @joeljfischer, thanks for your contribution! 🔍 Code Review will be done tomorrow. BTW: |
|
Please rebase. |
|
@ochococo done |
| @@ -35,6 +35,10 @@ | |||
| </dict> | |||
| <key>UIMainStoryboardFile</key> | |||
| <string>Main</string> | |||
| <key>UIAppFonts</key> | |||
| <array> | |||
| <string>Climacons.ttf</string> | |||
There was a problem hiding this comment.
Do you/we have rights to this font?
There was a problem hiding this comment.
It's an open-source font, the terms explicitly state that they may be used in any personal or commercial use (at the bottom of the page).
|
No more comments. Please rebase. |
|
Done |
|
Yay! Don't know why the images didn't get committed last time. |
|
The code looks ok 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are checked before submitting your Pull Request - thank you!
Resolves #97
This PR is for a pretty basic weather widget showing the current temperature and a weather icon, the the next three days' high/low temp and a weather icon, and the current wind conditions.