Add collector const labels #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assafad
reviewed
Mar 26, 2024
Signed-off-by: machadovilaca <machadovilaca@gmail.com>
machadovilaca
force-pushed
the
add-collector-const-labels
branch
from
fdb158b
to
ccb9b34
Compare
assafad
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes when using collectors you might not know every necessary label
on compile time. This PR allows users to pass a set of const labels directly to
the collector result. This might be used when you want to, for example,
collect metrics about Kubernetes cluster resources, and want to include
some additional variable metadata from that resource.