Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move alert description validation to be optional #6

Merged
merged 1 commit into from Mar 5, 2024

Conversation

assafad
Copy link
Collaborator

@assafad assafad commented Mar 5, 2024

Many alert rules have summary annotation, but not description, and this is valid, since description is not mandatory. This PR moves the alert description validation to be optional.

@machadovilaca
Copy link
Owner

can you sign the commit @assafad?

@assafad
Copy link
Collaborator Author

assafad commented Mar 5, 2024

can you sign the commit @assafad?

I think it's signed already, isn't it?

@assafad assafad force-pushed the description-validation branch 3 times, most recently from de539cb to 5c468ca Compare March 5, 2024 15:36
@machadovilaca
Copy link
Owner

Signed-off-by: assafad <aadmi@redhat.com>
@machadovilaca machadovilaca merged commit 24620e2 into machadovilaca:main Mar 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants