libActivities #37
libActivities #37
Conversation
|
@scunz I just cleaned up the issues, putting everything in the right places (well, technically 😄). How about setting up a "real" integration branch like In theory, we could use those branches to built and check preview releases (milestones) by Jenkins. |
|
⚡ Build fails: /home/nils/Projects/MacGitver/Libs/libActivities/Activity.cpp:79:13: error: use of undeclared identifier 'assert'
assert(running + success > 0);
^@scunz Something's missing? |
|
You're on linux, right? |
|
Yes, I'm on Linux. There's a few more compile errors of the same kind after fixing this one. Further some typos cause problems in the include section on case sensitive file systems. Shall I commit the fixes to the sacu/activities branch? Btw.: Why not use Q_ASSERT macro instead? |
|
Yes, please commit them on top of this (Not sure if you already did, but if so, rebase and push again, please). I've just rebased everything once more and force-push'ed it (without seeing your comment). There's obviously something wrong with github and my mail... |
When we'll move most of Internal to Data, the Dumper class resides where it is. So this'll make things easier later on
|
@scunz Hm ... the other fixes belong to libRepoMan. Should I commit them here anyways? |
|
Again, no notification per email. Think I've to ask GH Support for that one now. @antis81, yes, commit them here to not-block yourself. But bear in mind that I'm in the process of un-fucking my mistakes in the repoman and I'm constantly rebasing it, so I can get the contents of the 3 "big" commits separated out. While I'm doing that, it's likely that there will be new temporary breakage introduced and some will vanish occasionally. The goal is to have every commit in repoman compile by itself. So, if you commit repoman fixes here, I'll take care that repoman is changed in a way that these problems don't exist in the first place - but to do that earlier I need to be aware of them; otherwise they'll probably not be fixed before I'm at that stage... |
Still lacking lots of implementation and a good testcase.
|
rebased again. In addition to my previous comment: I.e. spot all the commits with "Fixup" in their name. They're meant to be moved into some other commit at some point. |
Author @antis81:
To follow discussion and implementation status of all the related PR's, please head over to MGV-Redmine.