Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

analyzeCss.js: lazy load analyze-css module via await import() #1169

Open
wants to merge 5 commits into
base: devel
Choose a base branch
from
Open

analyzeCss.js: lazy load analyze-css module via await import() #1169

wants to merge 5 commits into from

Conversation

macbre
Copy link
Owner

@macbre macbre commented Jun 14, 2022 •
edited

Prepare for analyze-css to be a pure ESM package - macbre/analyze-css#616

https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c - nice notes from @sindresorhus.

@macbre
eslint: allow dynamicImport syntax
d8174d0 
Solves:

 phantomas/modules/analyzeCss/analyzeCss.js
  92:29  error  'import()' expressions are not supported yet  node/no-unsupported-features/es-syntax
@macbre
Copy link
Owner Author

macbre commented Jun 25, 2022 

    You need to run with a version of node that supports ES Modules in the VM API. See https://jestjs.io/docs/ecmascript-modules

@macbre
Copy link
Owner Author

macbre commented Nov 21, 2022

Now that's interesting ...

$ npm t
(...)
Segmentation fault (core dumped)
npm ERR! Test failed.  See above for more details.

@gmetais gmetais mentioned this pull request Sep 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
esm-migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@macbre