Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Codeview PDB 2.0 debug directory format #409

Merged
merged 1 commit into from
May 20, 2024

Conversation

joschock
Copy link
Contributor

@joschock joschock commented May 7, 2024

Adds support for Codeview PDB 2.0 debug directory format.

Copy link
Owner

@m4b m4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how hard would it be to add a test?

@joschock
Copy link
Contributor Author

how hard would it be to add a test?

Is there a test for the existing codeview7 support? I poked a bit, but I didn't see one - but if so, it would be pretty straightforward to extend/modify for CV2. Otherwise, it's slightly more work. If desired, I could push up a subsequent PR with a test...

@joschock
Copy link
Contributor Author

@m4b - any objections to merging this as is? Or would you like me to push a test first?

@m4b m4b merged commit 6177758 into m4b:master May 20, 2024
6 checks passed
@m4b
Copy link
Owner

m4b commented May 20, 2024

note: breaking change

tests for this would be nice at some point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants