Develop #2
Open
Develop #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deel1931
reviewed
Jan 22, 2021
|
|
||
| function delete_comment(){ | ||
| $filename = "comment.csv"; | ||
| $c_id = $_POST['c_id']; |
There was a problem hiding this comment.
c_idだとなんのIDかわからないのでcommet_idなどわかりやすいものにした方が良いと思います。
There was a problem hiding this comment.
僕もよくレビューしてもらう時に変数のネーミングで怒られたりするのですが、変数のネーミングをしっかりする理由は業務目線になりますが、相手がパッとコードを見た時にどの変数が入っているかわかりやすいとエラーの改善箇所が見つけやすいのと、コード量が長くなっても変数がわかり易ければコードを追いやすい、さらに自分の後任の人が作業に入りやすくするためだと個人的には考えていて、変数の命名は僕も毎回すごい悩んだりするので意識してかくと自分もあとで見やすくなると思います！
| ?> | ||
| <div class="comment_form"> | ||
| <form action="" method='post' onsubmit="return add_confirm()"> | ||
| <dl> |
There was a problem hiding this comment.
dl>dt+dd
良いですね。まさにここは使いどころですよね
| } | ||
| ?> | ||
| <div class="comment_form"> | ||
| <form action="" method='post' onsubmit="return add_confirm()"> |
There was a problem hiding this comment.
actionが空でも大丈夫でしょうか？可能であれば中身書いてもらった方が一般的なのでレビューしてる側としても安心できます
| ?> | ||
| <div class="comment"> | ||
| <p><?php echo $comment[2] ?></p> | ||
| <p><?php echo $comment[3] ?></p> |
There was a problem hiding this comment.
これだとコメントは二つまでしか表示されないのではないでしょうか？
間違っていたらすいません。
index.php
Outdated
| function judge(){ | ||
| if($_SERVER['REQUEST_METHOD'] === 'POST'){ | ||
| if(empty($_POST['title']) || empty($_POST['sentence'])){ | ||
| $msg = "タイトル,本文のは必須入力です"; |
index.php
Outdated
| } | ||
| fclose($fp); | ||
| $file_array = array_reverse($file_array); | ||
| $now = 1; |
There was a problem hiding this comment.
$nowだとわかりにくいので
$page_num
でも良いかと思います
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
質素ですが、完成しました
レビューをお願いします