Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Fix 2 bugs to get program working. #138

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ddan39
Copy link

@ddan39 ddan39 commented Nov 2, 2023

Fixes 2 bug. 1 with the pactl commands, other with the sox vol argument. The program seems to be working now, at least for me with pulseaudio, not pipewire-pulse. Note that I did also change the "node.description" argument you provided to pactl before to "sink_properties=device.description=" and "source_properties=device.description=". The node.description wasn't working for me. I tried to get the spaces in the descriptions to work by typing it like 'sink_properties=device.description="Lyrebird Output"' but that wouldn't work for me either, so I just changed it to underscores.

…ecause of spaces in what should be single arguments
…ed for the vol argument it defaults to amplitude. 0 amplitude is absolute silence. To leave the volume unchanged we change it to amplitude 1, but to keep consistent with the code above that uses dB, I am going to set it to "0dB".
@PapaBravo
Copy link

Thanks Dan!
I just wanted to add that this fix worked for me on Ubuntu 22.04

@ghost
Copy link

ghost commented Nov 8, 2023

@ddan39 Thanks Dan, forgive me I missed this when this came in a week ago.

On both old-school PulseAudio and pipewire-pulse the current main branch works fine for me so I just some questions:

  1. What distro version are you using?
  2. Are you using old-school PulseAudio or pipewire-pulse?
  3. Just to confirm, without this patch Lyrebird doesn't work for you? If so, in what way? I assume that the sink isn't initializing for you.
  4. And does replacing node.description with source_properties=device.description fix the issues you're facing?

@ddan39
Copy link
Author

ddan39 commented Nov 8, 2023 via email

@develroo
Copy link

develroo commented Dec 1, 2023

Yup can confirm. Worked for me on Debian testing as well. Just edited the file and aside from the noticeable delay works fine.

Just need to figure out how to stop it defaulting to the internal mic every time I switch voice or turn it off. sighs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants