Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Added support for more effects both in presets and UI #101

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Mortasen
Copy link

Hello! Recently I discovered this beautiful program, and liked the simplicity of the interface very much, but it seemed odd to me that the only parameter user can change is pitch, so I decided to change this. Namely, the changes I made:

  1. Replaced hardcoded parameters for specific effects by effects dictionary in Preset, which contains effects' names as keys and arrays with parameters as values.
  2. Changed the code for default presets so it corresponds to this new principle - effect name as key, and array with parameters to this effect as value.
  3. Wrote a function build_parameter_row, which handles all the code needed for adding new scales and make it require minimum code changes.
  4. Updated other functions, such as build_sox_command or scale_moved respectively.
  5. Moved some duplicated code to functions, such as restart_sox or set_preset.
  6. Added scales for two new effects, lowpass and highpass, and switches for all the effects to turn them off if not needed.

Unfortunately, I don't know much about how to properly test it, but on my laptop it seems to work fine, so I hope it's the same with others :)

This is my first pull request, so please do not judge strictly if there's something wrong. Let me know about the issues and maybe I'll be able to fix them! Thanks in advance.

@ghost
Copy link

ghost commented Aug 17, 2023

We're currently working on version 2 which is in the v2 branch which will have a hybrid Pulse/Pipewire audio backend. I appreciate the code here and will work on merging it in when the playback side of the backend is complete, I'll follow-up when I'm ready.

@ghost ghost force-pushed the main branch 2 times, most recently from 8e0d57c to 1acd301 Compare August 20, 2023 18:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant