This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Added support for more effects both in presets and UI #101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Recently I discovered this beautiful program, and liked the simplicity of the interface very much, but it seemed odd to me that the only parameter user can change is pitch, so I decided to change this. Namely, the changes I made:
effects
dictionary in Preset, which contains effects' names as keys and arrays with parameters as values.build_parameter_row
, which handles all the code needed for adding new scales and make it require minimum code changes.build_sox_command
orscale_moved
respectively.restart_sox
orset_preset
.Unfortunately, I don't know much about how to properly test it, but on my laptop it seems to work fine, so I hope it's the same with others :)
This is my first pull request, so please do not judge strictly if there's something wrong. Let me know about the issues and maybe I'll be able to fix them! Thanks in advance.