Adding support for External URL when adding a new backend #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushbilala
force-pushed
the
externalUrlFix
branch
from
4a01b74
to
44b9c62
Compare
|
@ayushbilala would you fix your commit to make the check pass? Then someone at Lyft may review and approve the PR? You may need to add tests for this as well, I would suggest checking out |
|
Fixes #151 |
ayushbilala
force-pushed
the
externalUrlFix
branch
from
44b9c62
to
eeb028f
Compare
|
@ddcprg Sure, I'll make the change. |
ayushbilala
force-pushed
the
externalUrlFix
branch
from
2fc034a
to
b71b936
Compare
|
I have made the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding a new backend, externalUrl is not getting ingested in the database. This PR adds support for the same.