This repository has been archived by the owner on Jan 5, 2023. It is now read-only.
Merge from kubeflow/katib #13
Open
+111,380
−3,806,865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
meow @vinaykakade |
* docs: update new algorithm service details * feat: trial augmentation strategy * feat: pbt suggestion service * feat: PbtTemplate and associated test image * feat: introduce annotation field to trial specifications * feat: trial assignment changes to support annotations from suggestion - Add new Annotation types to suggestion_types.go - Add Annotation object and update Trial parser in trial.py * feat: update pbt suggestion to use new Annotation api - Suggestion uses exact match to track spawned trials - Trials that get transmitted, but not created (or added to experiment) are added back to the respawn pool (population_size consistency) * chore: gofmt and black run across PBT changes * feedback: remove tf summary export, change default print unit, reduce range to be percentage compatible. * feedback: move PBT template to example. * feedback: changes to inject_webhook and utils. - Rename mutateVolume to mutateMetricsCollectorVolume - Add addContainerVolumeMount - Add getPrimaryContainerIndex * feedback: change suggestion mutation mount variable name and add to consts * feedback: Add trial_names to GetSuggestionsReply and change suggestion path to <experiment>/<trial> * feedback: removed unnecessary checks and moved to async pbt implementation * feedback: update trial name override location and change annotations override to labels. * feedback: add pbt to github workflow * feedback: move labels to ParameterAssignments in GetSuggestionsReply and cleanup pbt.yaml. * feedback: remove operator changes * feedback: GHA updates * feedback: new formatting changes * feedback: add suggestion-pbt to gh-actions build-load.sh. * fix: missing pbt->simple-pbt name changes, add simple-pbt to update-images.sh update yaml function (causing failing gha). * feedback: add pointer to website from main readme for pbt
* Fix missing document start warnings * Fix too few spaces before comment warning
* Add yamllint checking * Update yamllint command * Revert changes to charmed * Create new workflow for yamllint * Create a script to verify installation and run yamllint * Add `make yamllint` * Update lint workflow
Signed-off-by: Jaeyeon Kim <anencore94@gmail.com>
* implement validation for darts service * Update pkg/suggestion/v1beta1/nas/darts/service.py Co-authored-by: Jaeyeon Kim(김재연) <anencore94@gmail.com> * Update pkg/suggestion/v1beta1/nas/darts/service.py Co-authored-by: Jaeyeon Kim(김재연) <anencore94@gmail.com> * [review] delete todo comment * [review] change function name validate_algorithm_settings to validate_algorithm_spec * [review] fix vaiolation comments * [review] fix condition to validate batch_size * [review] add comment for developers * [review] use set instead of list Co-authored-by: Jaeyeon Kim(김재연) <anencore94@gmail.com>
* implement postgres for katib db * fix yaml lint * apply go mod tidy * Update manifests/v1beta1/components/postgres/postgres.yaml Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com> * refactoring by reviews - split openconnection to common packages - add unit test for postgres db * change to install only mysql by default * remove useless import * add postgres kustomization and e2e test for it * change mysql installation files to be variable * fix shell scripts * fix lint * fix image name * set default value on github action workflow * make postgres deployment to use pvc * temporarily comments * uncomment invalid experiments * test with for loop * sleep until controller created well * add some comments * Update pkg/db/v1beta1/postgres/postgres.go Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com> * Update pkg/db/v1beta1/postgres/postgres_test.go Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com> * refactor by reviews Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
* introduce Automatic platform ARGs Automatic platform ARGs: https://docs.docker.com/engine/reference/builder/#automatic-platform-args-in-the-global-scope * use BuildKit in actions test for charmed-katib * use docker buildx in scripts/v1beta1/build.sh
#1936) * add validation webhooks for maxFailedTrialCount and parallelTrialCount * [review] simplify validation logic
* Use new distributions in Optuna v3 * Update optuna to v3
* support for arm64 in mxnet-mnist image * fix build script
Signed-off-by: tenzen-y <yuki.iwai.tz@gmail.com> Signed-off-by: tenzen-y <yuki.iwai.tz@gmail.com>
Signed-off-by: tenzen-y <yuki.iwai.tz@gmail.com> Signed-off-by: tenzen-y <yuki.iwai.tz@gmail.com>
Signed-off-by: tenzen-y <yuki.iwai.tz@gmail.com> Signed-off-by: tenzen-y <yuki.iwai.tz@gmail.com>
Signed-off-by: tenzen-y <yuki.iwai.tz@gmail.com> Signed-off-by: tenzen-y <yuki.iwai.tz@gmail.com>
Signed-off-by: Kun Chang <curtis@mail.ustc.edu.cn>
* Update architect.py 72907153+sifa1024@users.noreply.github.com Signed-off-by: Chen Pin-Han <72907153+sifa1024@users.noreply.github.com> * Update run_trial.py 72907153+sifa1024@users.noreply.github.com Signed-off-by: Chen Pin-Han <72907153+sifa1024@users.noreply.github.com> * Update architect.py 72907153+sifa1024@users.noreply.github.com Signed-off-by: Chen Pin-Han <72907153+sifa1024@users.noreply.github.com> --------- Signed-off-by: Chen Pin-Han <72907153+sifa1024@users.noreply.github.com>
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
* chore: add unit testcases for files in Text format. Signed-off-by: Electronic-Waste <2690692950@qq.com> * chore: adjust file layout using gofmt. Signed-off-by: Electronic-Waste <2690692950@qq.com> * chore: combine test for JSON and TEXT file format. Signed-off-by: Electronic-Waste <2690692950@qq.com> * fix: rename file-gen functions. Signed-off-by: Electronic-Waste <2690692950@qq.com> * refactor: update cmd.Diff params and log outputs. Signed-off-by: Electronic-Waste <2690692950@qq.com> * chore: add more valid and invalid testcases for TEXT format. Signed-off-by: Electronic-Waste <2690692950@qq.com> * chore: convert testcase name to const. Signed-off-by: Electronic-Waste <2690692950@qq.com> * chore: compact dir generation & deletion operations into funcs. Signed-off-by: Electronic-Waste <2690692950@qq.com> * fix: delete constants used only once. Signed-off-by: Electronic-Waste <2690692950@qq.com> * fix: fix ci error in errorcheck. Signed-off-by: Electronic-Waste <2690692950@qq.com> --------- Signed-off-by: Electronic-Waste <2690692950@qq.com>
* Upgrade Python version to 3.11 Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> * Upgrade the numpy version to 1.25.2 Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> * Increase resource requests for the ENAS suggestion service Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> * Update pytest CI Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> * Prepare dedicated pytest for skopt Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> --------- Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
…nd (#2287) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.6. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.4...v1.15.6) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…mpatible (#2292) Bumps [github.com/docker/docker](https://github.com/docker/docker) from 24.0.0+incompatible to 24.0.9+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v24.0.0...v24.0.9) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps google.golang.org/protobuf from 1.30.0 to 1.33.0. --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [jose](https://github.com/panva/jose) from 2.0.6 to 2.0.7. - [Release notes](https://github.com/panva/jose/releases) - [Changelog](https://github.com/panva/jose/blob/v2.0.7/CHANGELOG.md) - [Commits](panva/jose@v2.0.6...v2.0.7) --- updated-dependencies: - dependency-name: jose dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.1.0 to 0.17.0. - [Commits](golang/crypto@v0.1.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.53.0 to 1.56.3. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.53.0...v1.56.3) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.10.0 to 0.17.0. - [Commits](golang/net@v0.10.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…2272) * added dco Signed-off-by: Bharath Krishna <bharathk005@gmail.com> * updated condition Signed-off-by: Bharath Krishna <bharathk005@gmail.com> * added exception to catch missing name and generateName Signed-off-by: Bharath Krishna <bharathk005@gmail.com> * updated experiment_name in create_experiment Signed-off-by: Bharath Krishna <bharathk005@gmail.com> * py sdk create_exp - added type validation Signed-off-by: Bharath Krishna <bharathk005@gmail.com> * added dco Signed-off-by: Bharath Krishna <bharathk005@gmail.com> * updated condition Signed-off-by: Bharath Krishna <bharathk005@gmail.com> * added exception to catch missing name and generateName Signed-off-by: Bharath Krishna <bharathk005@gmail.com> * updated experiment_name in create_experiment Signed-off-by: Bharath Krishna <bharathk005@gmail.com> * py sdk create_exp - added type validation Signed-off-by: Bharath Krishna <bharathk005@gmail.com> --------- Signed-off-by: Bharath Krishna <bharathk005@gmail.com>
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
* Upgrade TensorFlow version to v2.16.1 Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> * Replace deprecated ImageDataGenerator with new data augmentation approach Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> --------- Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
* chore: replace testDir with tempDir. Signed-off-by: Electronic-Waste <2690692950@qq.com> * fix: expose and compare errors. Signed-off-by: Electronic-Waste <2690692950@qq.com> * refactor: integrate test generation func into testCases. Signed-off-by: Electronic-Waste <2690692950@qq.com> * refactor: update error comparing mechanism. Signed-off-by: Electronic-Waste <2690692950@qq.com> * fix: make some changes under the review of yuki. Signed-off-by: Electronic-Waste <2690692950@qq.com> --------- Signed-off-by: Electronic-Waste <2690692950@qq.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.19.0 to 0.23.0. - [Commits](golang/net@v0.19.0...v0.23.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Support ARM arch for release images Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Update Developer Doc Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> --------- Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: tariq-hasan <mmtariquehsn@gmail.com>
Signed-off-by: Mehrshad <code.rezaei@gmail.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Jerry-yz <yz386071268@gmail.com>
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.