[Helm] Add Lightbend's helm chart definition #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rator to codebase
pedro93
requested review from
anandswaminathan,
maghamravi and
premsantosh
as code owners
anandswaminathan
approved these changes
May 24, 2021
|
@maghamravi Can you take a 👀 as well ? |
maghamravi
reviewed
May 26, 2021
| - flink | ||
| home: https://github.com/lyft/flinkk8soperator | ||
| maintainers: | ||
| - name: Lightbend Cloudflow Team |
There was a problem hiding this comment.
I respect Lightbend Cloudflow team for their contribution. Curious, do we a have their approval to be listed as maintainers ?
maghamravi
reviewed
May 26, 2021
| name: flink-operator | ||
| description: A Helm chart for Flink operator | ||
| version: 0.8.2 | ||
| appVersion: 0.4.0 |
There was a problem hiding this comment.
Thoughts on having the chart config and templates against master version 0.5.0 ? Ideal to keep it in sync to avoid customer surprises.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Lightbend's helm chart definition of this repository as the original repository is no longer maintained as mentioned in this issue and following a suggestion from the slack channel.
This is a direct copy, no changes to the underlying code have been made.
Disclaimer: I am not the owner or maintainer of either repository.
Feel free to suggest appropriate changes, I will do my best to follow through.
Thank you.