Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add config option to disable title capitalization #408

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add config option to disable title capitalization #408

wants to merge 1 commit into from

Conversation

ericswpark
Copy link
Contributor

Description

Users can set disableTitleCapitalization to true in order to, well, disable title capitalization.

Issue Number

Fixes #368

Additional Information (Optional)

I wrote this on my phone so it may not work?

Checklist

Yes, I included all necessary artefacts, including:

  • Tests
  • Documentation
  • Implementation (Code and Ressources)
  • Example

Documentation moved to wiki since I last contributed here, so once this PR is merged I guess the wiki could be edited?

Testing Checklist

Yes, I ensured that all of the following scenarios were tested:

  • Desktop Light Mode (Default)
  • Desktop Dark Mode
  • Desktop Light RTL Mode
  • Desktop Dark RTL Mode
  • Mobile Light Mode
  • Mobile Dark Mode
  • Mobile Light RTL Mode
  • Mobile Dark RTL Mode

Notify the following users

@ericswpark
feat: add config option to disable title capitalization
69c9769 
Users can set disableTitleCapitalization to true in order to, well,
disable title capitalization.

Fixes lxndrblz#368
@netlify
Copy link

netlify bot commented Dec 17, 2022 •
edited

✅ Deploy Preview for anatole-demo ready!

Name Link
🔨 Latest commit 69c9769
🔍 Latest deploy log https://app.netlify.com/sites/anatole-demo/deploys/639de0a9552e4e0009c72bf7
😎 Deploy Preview https://deploy-preview-408--anatole-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Dec 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lxndrblz lxndrblz self-assigned this Mar 27, 2023
@lxndrblz
Copy link
Owner

@ericswpark Thanks for your PR. I wonder if that's really sufficient
Shouldn't the capitalization also be disabled on the portfolio page and in the post series snippet?

@ericswpark
Copy link
Contributor Author

@lxndrblz it really is a rough draft I wrote on my phone so I may have (read: probably will have) missed a ton.

In addition this PR doesn't affect any CSS rules, as noted in the original issue report. I opted not to include it because a) I don't know how to disable CSS rules based on Hugo configuration, and b) we still need to figure out whether to have it configurable in one configuration option or in a separate one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lxndrblz lxndrblz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable title capitalization
2 participants
@ericswpark @lxndrblz