Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable title capitalization #368

Open
McPringle opened this issue Jun 16, 2022 · 9 comments · May be fixed by #408
Open

Disable title capitalization #368

McPringle opened this issue Jun 16, 2022 · 9 comments · May be fixed by #408
Assignees
Labels
enhancement New feature or request

Comments

@McPringle
Copy link

Is your feature request related to a problem? Please describe.
In some languages using capitalization of titles looks awesome because they have strict rules and capitalization is not a style, but a meaning (e.g. capitalized words are nouns).

Describe the solution you'd like
Please don't use the "title" processor in the template file. Use CSS instead. That makes it much easier to change the capitalization as wanted:

text-transform: capitalize

As a user of your theme I will now be able to override the CSS style to disable capitalization if I need to:

text-transform: none

Describe alternatives you've considered
I can provide my own single.html file. But when I do it, I have to monitor your changes in your single.html and merge them with my modifications. I prefer to use the CSS solution instead.

Additional context
Add any other context or screenshots about the feature request here.

@McPringle McPringle added the enhancement New feature or request label Jun 16, 2022
@ericswpark
Copy link
Contributor

@McPringle just to confirm, you want to disable the capitalization of titles in the post list, right? I had to make this change too and found that this temporary workaround helped:

assets/css/list-title.css:

.archive__list-title {
     text-transform: none;
 } 

config.toml:

customCss = ["css/list-title.css"]

While this works it would be great if we could turn off capitalization in the configuration.

@McPringle
Copy link
Author

Sorry, no, I want to disable it on the single page, not in the lists.

@lxndrblz
Copy link
Owner

lxndrblz commented Jun 21, 2022

@McPringle Would you mind opening a PR with the proposed change?

I agree with your suggestions. Especially in German capitalization matters.

@McPringle
Copy link
Author

Next week we are doing a Hackergarten in Lucerne and I'll suggest this issue as a topic.

@lxndrblz
Copy link
Owner

@McPringle Were you able to work on it as part of your hackathon?

@ericswpark
Copy link
Contributor

I just realized what @McPringle meant by the capitalization problem and once I noticed it I really wish we could turn it off, as it mangles some of my blog post titles.

@lxndrblz could we make it an option to disable title capitalization in single pages?

@McPringle
Copy link
Author

Unfortunately, this issue was not picked up at the Hackergarten. But winter is coming with more evenings at home... ;-)

ericswpark added a commit to ericswpark/anatole that referenced this issue Dec 17, 2022
Users can set disableTitleCapitalization to true in order to, well,
disable title capitalization.

Fixes lxndrblz#368
@ericswpark ericswpark linked a pull request Dec 17, 2022 that will close this issue
12 tasks
@ericswpark
Copy link
Contributor

@lxndrblz @McPringle just drafted a rough commit that adds a configuration option for single page titles.

I was also thinking about having the config option change the archive (list) title capitalization as well since I'd like to turn that off too but I realized that one is in all caps, so it's more of a stylistic choice? So either:

a) change the configuration option name to disableTitleStyling and have it disable all title styling (dunno how that would work on scss files though) or
b) change this configuration option name to disableSinglePageTitleCapitalization and create a separate, new PR for disableArchiveTitleStyling or something like that. (Maybe the config name is too long. Or not.)

@McPringle
Copy link
Author

Fantastic! For me variant b) would be enough, but variant a) would be fine, too. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants