Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed camera model to pinhole (no lens distortion) for non-wide cameras #1094

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CenekAlbl
Copy link
Contributor

Should be more stable for small number of calibration images.

…on procedure of non-wide cameras. Should be more stable for small number of calibration images.
@saching13
Copy link
Contributor

if reprojection_error_threshold is high too high then doesn't it affect the users who try to use it with pnp ?

@CenekAlbl
Copy link
Contributor Author

I needed to set higher reprojection error treshold to accomodate for lower number of camera parameters. Not sure about the value honestly - these numbers worked for the 3 cameras I had factory images for, but might still introduce failed calibrations on others. I think we should either validate with more cameras or incease it even further. What do you mean exactly by affect pnp?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants