Raise AuthenticationError from the service load() method if not authe…

…nticated.

Some services have odd errors that I don't understand, and I've just left those alone for now.

lutris/services/amazon.py

@@ -156,8 +156,8 @@ def is_connected(self):
     def load(self):
         """Load the user game library from the Amazon API"""
         if not self.is_connected():
-            logger.error("User not connected to Amazon")
-            return
+            raise AuthenticationError("User not connected to Amazon", self.id)
+
         games = [AmazonGame.new_from_amazon_game(game) for game in self.get_library()]
         for game in games:
             game.save()

lutris/services/egs.py

@@ -295,7 +295,6 @@ def load(self):
         try:
             library = self.get_library()
         except Exception as ex:  # pylint=disable:broad-except
-            logger.warning("EGS Token expired")
             raise AuthenticationError("EGS Token expired", self.id) from ex
         egs_games = []
         for game in library:

lutris/services/gog.py

@@ -132,8 +132,8 @@ def is_connected(self):
     def load(self):
         """Load the user game library from the GOG API"""
         if not self.is_connected():
-            logger.error("User not connected to GOG")
-            return
+            raise AuthenticationError("User not connected to GOG", self.id)
+
         games = [GOGGame.new_from_gog_game(game) for game in self.get_library()]
         for game in games:
             game.save()

lutris/services/humblebundle.py

@@ -8,7 +8,7 @@
 from gi.repository import Gtk
 
 from lutris import settings
-from lutris.exceptions import UnavailableGameError
+from lutris.exceptions import AuthenticationError, UnavailableGameError
 from lutris.gui.dialogs import HumbleBundleCookiesDialog, QuestionDialog
 from lutris.installer import AUTO_ELF_EXE, AUTO_WIN32_EXE
 from lutris.installer.installer_file import InstallerFile
@@ -115,7 +115,9 @@ def load(self):
         try:
             library = self.get_library()
         except ValueError as ex:
-            raise RuntimeError("Failed to get Humble Bundle library. Try logging out and back-in.") from ex
+            raise AuthenticationError(
+                "Failed to get Humble Bundle library. Try logging out and back-in.", self.id
+            ) from ex
         humble_games = []
         seen = set()
         for game in library:

lutris/services/itchio.py

@@ -9,7 +9,7 @@
 
 from lutris import settings
 from lutris.database import games as games_db
-from lutris.exceptions import UnavailableGameError
+from lutris.exceptions import AuthenticationError, UnavailableGameError
 from lutris.installer import AUTO_ELF_EXE, AUTO_WIN32_EXE
 from lutris.installer.installer_file import InstallerFile
 from lutris.services.base import SERVICE_LOGIN, OnlineService
@@ -144,8 +144,7 @@ def is_connected(self):
     def load(self):
         """Load the user's itch.io library"""
         if not self.is_connected():
-            logger.error("User not connected to itch.io")
-            return
+            raise AuthenticationError("User not connected to itch.io", self.id)
 
         library = self.get_games()
         games = []