This repository has been archived by the owner on Apr 2, 2021. It is now read-only.
modbus: Prevent panic with registers more than max-register apart #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modbus supports querying 2000 digital registers or 125 analog registers at a time. If a user would configure multiple e.g. analog registers, that can not be quieried with a single query (=> not within 125 distance), then the exporter would try to access indices in the returned byte slice bigger than the max-register size (125). This patch: - Makes sure to only access indices within the max register size (2000 / 125). - Breaks the loop once all registers have been found. - Adds test framework as well as two tests for `getModbusData`. - Adds project binary to `.gitignore`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modbus supports querying 2000 digital registers or 125 analog registers
at a time. If a user would configure multiple e.g. analog registers,
that can not be quieried with a single query (=> not within 125
distance), then the exporter would try to access indices in the returned
byte slice bigger than the max-register size (125).
This patch:
Makes sure to only access indices within the max register size (2000 /
125).
Breaks the loop once all registers have been found.
Adds test framework as well as two tests for
getModbusData.Adds project binary to
.gitignore.