flake8: B028 got renamed to B907. See link in the description #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoepVanlier
reviewed
May 10, 2023
There was a problem hiding this comment.
Hmm... I'm on the fence whether to change all these warnings now or wait for the next major version to do it. While it is a bugfix, it is a breaking change since changing the stacklevel to 2 will cause certain warnings to change in existing code (and potentially on any other CI that uses pylake).
Updating this would be nice.
|
I wonder if doing something similar as Basically, they find the first stack level that isn't in pandas and use that one. |
JoepVanlier
force-pushed
the
tobiasjj/fix_flake8
branch
9 times, most recently
from
065d28f
to
97479d4
Compare
JoepVanlier
force-pushed
the
tobiasjj/fix_flake8
branch
from
97479d4
to
0eb6fe0
Compare
JoepVanlier
force-pushed
the
reformat_tests
branch
from
415e510
to
6cf6907
Compare
JoepVanlier
force-pushed
the
tobiasjj/fix_flake8
branch
from
0eb6fe0
to
08d3719
Compare
JoepVanlier
force-pushed
the
tobiasjj/fix_flake8
branch
2 times, most recently
from
b6b76a8
to
2971af5
Compare
JoepVanlier
force-pushed
the
tobiasjj/fix_flake8
branch
from
2971af5
to
177fef5
Compare
JoepVanlier
force-pushed
the
tobiasjj/fix_flake8
branch
from
177fef5
to
424fa8e
Compare
JoepVanlier
force-pushed
the
tobiasjj/fix_flake8
branch
from
424fa8e
to
48bea15
Compare
JoepVanlier
force-pushed
the
tobiasjj/fix_flake8
branch
from
48bea15
to
ea89a78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyCQA/flake8-bugbear#333
This PR adjusts the ignore rule of flake8, accordingly.