Separate train_x_all and train_x_bc in PDE #1731
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, arrays of points
train_x_all
andtrain_x_bc
are mixed. Because of this, some points are duplicated, which can be critical with a large volume.Look at the example:
Shapes before PR:
train_x
(100, 1)train_x_all
(75, 1)train_x_bc
(25, 1)Shapes after PR:
train_x
(75, 1)train_x_all
(50, 1)train_x_bc
(25, 1)Another example with
num_domain
equals 0Shapes before PR:
train_x
(50, 1)train_x_all
(25, 1)train_x_bc
(25, 1)Shapes after PR:
train_x
(25, 1)train_x_all
(0, 1)train_x_bc
(25, 1)