Allow specifying amount of boundary condition test points #1108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something similar can be done in
data/pde_operator.py
and I may do this in a future pull request.Should I add
num_test_boundary
to the examples? I'm not sure if this is a problem in the real-world. It seems to me that doing this would prevent (or at least detect) overfitting to the boundary conditions selected.I also fixed a trivial TODO in
pde.py
(renametrain_x_all
totrain_x_pde
). Let me know if you want me to split this into a seperate PR.