Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying amount of boundary condition test points #1108

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

g-w1
Copy link
Contributor

@g-w1 g-w1 commented Jan 12, 2023

Something similar can be done in data/pde_operator.py and I may do this in a future pull request.

Should I add num_test_boundary to the examples? I'm not sure if this is a problem in the real-world. It seems to me that doing this would prevent (or at least detect) overfitting to the boundary conditions selected.

I also fixed a trivial TODO in pde.py (rename train_x_all to train_x_pde). Let me know if you want me to split this into a seperate PR.

@lululxvi
Copy link
Owner

I also fixed a trivial TODO in pde.py (rename train_x_all to train_x_pde). Let me know if you want me to split this into a seperate PR.

Yes, too many changes in this PR. Please split.

@g-w1
Copy link
Contributor Author

g-w1 commented Jan 15, 2023

Yes, too many changes in this PR. Please split.

I have split it into #1113 .

@lululxvi
Copy link
Owner

lululxvi commented Jan 16, 2023

There might be some classes that also use num_test. You need double check.

@lululxvi
Copy link
Owner

Another main issue is that in losses, we use self.num_bcs for both training and testing. If you generate test boundary points separately, then self.num_bcs doesn't work for test points.

@g-w1
Copy link
Contributor Author

g-w1 commented Jan 16, 2023

I will modify ide.py and fpde.py to add num_test_domain and num_test_boundary and will create self.num_bcs_train and self.num_bcs_test. Thank you for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants