-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add author in posts info #173
base: master
Are you sure you want to change the base?
Conversation
sorry for the miss-closing... |
HI @lukeorth
I bumped into a slight issue while working on this PR and I'd really like your view on it. Description of the problemCurrently in
In the case of But in the case of Also, in both case we hardcode the taxonomy ( Possible solution1. Do nothing about itIt's not a major issue ofc. Why bother and lose time looking for "the" best solution, and maybe I should just add a 2. Keep hardcoding taxonomies but use
|
given recent update on this thread I opened on HUGO's forum I'd say that this solution suggested by one of HUGO's dev would be even better:
|
use HUGO's designed method to do it code suggested by jmooring: https://discourse.gohugo.io/t/what-can-cause-infinite-recursion-can-dumping-taxonomies-cause-it/49029/3
closes #170
Description
As discussed in the issue, if
author
is in the article's metadata add it just before the date in the post's infoMoreover, if
author
is a taxonomy for the website make it an hyperlink to/author/<author name>
What could be improved
Currently no CSS is added, and while the result seems good enough in dark mode with the hyperlink (see #170)
without the hyperlink it can be a bit "poor"
I'd like to give it its own style, like tags but I'm not very creative when it comes to GUI...
Also, when listing an author's post, I believe
layouts/_default/list.html
is used to list terms of a taxonomy if I trust the doc. But it "titlized" the taxonomy's term (here my nickname) thus not respecting the case:Ctmbl
instead ofctmbl
this is basically the same issue that #152, also https://discourse.gohugo.io/t/taxonomy-terms-permalink-spaces-vs-dashes/48629/5 might help
Forget that I noticed that hugo 0.123.0 introduced
capitalizelisttitles = false
that address my issueFinally it's a bit outside of the scope of this PR but it might be nice to add a guard for tags URLs, as I did for author, if
tags
is not a taxonomy for the website