Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display author in post info #170

Open
ctmbl opened this issue Mar 18, 2024 · 2 comments 路 May be fixed by #173
Open

Display author in post info #170

ctmbl opened this issue Mar 18, 2024 · 2 comments 路 May be fixed by #173

Comments

@ctmbl
Copy link

ctmbl commented Mar 18, 2024

I've searched poison's issues for similar feature proposal because I found it weird that nobody suggested such thing before but didn't find any, if I missed it, sorry for the duplicate issue 馃槄

Proposal

  • I'd like to had post author to the post info (if present in metadata) just before date in layouts/partials/post/info.html
  • The author could be an hyperlink, or not, given if author is a taxonomy or not to the website
  • I could add appropriated CSS if someone has a suggestion about how it could look 馃檪

Demo

it would look like this:
Screenshot_20240318_123620

(currently down but should be up soon at https://iscsc.fr/posts/publish-your-own-post)

@lukeorth
Copy link
Owner

Hi, @ctmbl -- thanks for the suggestion! I think this would be a great addition to the theme. Regarding how it should look, I think what you have in the screenshot looks good. It looks "on brand" with the rest of the theme.

If you want to put together a PR, I'd be happy to review. 馃檪

@ctmbl
Copy link
Author

ctmbl commented Mar 22, 2024

Hi @lukeorth tks for your positive answer!
I have a PR almost ready on my own fork, I'll open one here soon 馃槈

@ctmbl ctmbl linked a pull request Mar 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants