Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add server-sent events example #204

Merged
merged 5 commits into from
Jan 21, 2024

Conversation

antoine-coulon
Copy link
Contributor

Hello,

As discussed in #84, I just added an example with Server-Sent Events using polka.

I followed the same pattern as for other examples but let me know if you want me to add anything else.

Copy link
Owner

@lukeed lukeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please

  • use sirv instead of serve-static
  • use single quotes in the JS instead of doubles
  • remove empty newlines in the HTML

sorry for the nits :) looks good

@antoine-coulon
Copy link
Contributor Author

antoine-coulon commented Jan 18, 2024

It's all good this is legit, I'm usually using sirv myself... Just copied the wrong middleware folder I guess. Just did the changes (+ single quotes).

Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (58cb4f7) 100.00% compared to head (be90502) 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #204   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          104       104           
=========================================
  Hits           104       104           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukeed
Copy link
Owner

lukeed commented Jan 21, 2024

Thanks!

@lukeed lukeed merged commit a72e13c into lukeed:main Jan 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants