Update BusyBox base image to v1.34 #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version contains a fix to an issue uncompressing OS images zip files larger than 4GB.
carlosperate
changed the title
|
@lukechilds just a friendly ping, in case there is anything I could do to help the review. This is a small and fairly safe PR, just updating the BusyBox image version. |
carlosperate
added a commit
to carlosperate/docker-qemu-rpi-os
that referenced
this pull request
Jan 3, 2022
The current lukechilds/dockerpi:vm has an issue uncompressing fs images larger than 1 GB, so it has been temporarily forked with the fix More info: lukechilds/dockerpi#48
rasa
reviewed
Oct 31, 2023
| @@ -60,7 +60,7 @@ RUN make -j$(nproc) | |||
|
|
|||
|
|
|||
| # Build the dockerpi VM image | |||
| FROM busybox:1.31 AS dockerpi-vm | |||
| FROM busybox:1.34 AS dockerpi-vm | |||
There was a problem hiding this comment.
Latest version is 1.36 per https://hub.docker.com/_/busybox/tags
There was a problem hiding this comment.
Thanks @rasa! I'd be happy to update the PR if needed, but doesn't look like this project is being maintained :(
Hopefully having these PRs open can still help people encountering this issue.
I've been using a simple fork with this patch for my own images based on top of this one: https://github.com/carlosperate/dockerpi/pkgs/container/dockerpi/12649266?tag=vm-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version of BusyBox contains a fix to an issue uncompressing OS image zip files larger than 4GB: https://busybox.net
In my workflow I expand the OS image and when the file ends up bigger than 4GB it shows this zip error message and waits for user input:
After selecting and option it does work correctly, but waiting for user input is a problem for running these containers in CI.
Using the latest BusyBox fixes this and it uncompresses the zip file without these problems.