-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add LibreOffice icons #124
base: master
Are you sure you want to change the base?
Conversation
These files originate from ryanoasis/nerd-fonts#1527 by @Gaspartcho Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
Actually I wanted to also include LibreOffice specific icons here but since they a little complex I decided to not do it and use the generic office icons for this PR: eza-community/eza#565 @Gaspartcho, do you planned other use case apart from terminal? At least we can try to see how would be use them for LibreOffice files, they are very cool indeed. |
The reason I initially wanted to put these icons was that the text editor I use used the icons from NerdFonts in order to show file icons in the treeview |
I made a test and this is how it would look like with some different sizes with eza Here is the font if you want to test for your use case:
|
My opinion... The small details that make the icons different are a bit ... small. And hard to discern. Otoh I really hate these Microsoft centric icons with Edit: Also that |
Could be useful to make another test
Me too.
The |
The old icons already have 2 years from last update on help module: https://github.com/LibreOffice/help/tree/master/source/media/navigation which is the source from simple-icons The new ones are here, also from 2 years ago but have these modern, rounded design in core package: https://github.com/LibreOffice/core/tree/3ca12a07335e1e9ae6b64491faaab6a46e9c4db5/sysui/desktop/icons/hicolor/scalable/apps Branding page: https://wiki.documentfoundation.org/Design/Branding See difference: Edit: Testing branch -> https://github.com/hasecilu/font-logos/tree/test/libreoffice Previous icons are not rounded but their elements are slightly bigger. |
This is a comparative of different small sizes with the both group of icons. The first pack of logos are the older ones at original scale, the second pack contains the newer logos with an increase in the central glyphs to make it more differentiable at small scales (as would be expected on most terminal emulators). In the first pack the glyphs are well centered, in the second pack seems to be a more like in the bottom because of the top corner cut. |
Excellent. I believe they (your modified icons) look very good. Just some comment (of course 😉 )
Nice work! 👍 Edit: Add this image from 'afar': |
I guess you should just cherry pick your commits into this branch. After tweaking if you like. 🐱 |
These files originate from
by @Gaspartcho