Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add LibreOffice icons #124

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

WIP: Add LibreOffice icons #124

wants to merge 1 commit into from

Conversation

Finii
Copy link
Collaborator

@Finii Finii commented Mar 8, 2024

These files originate from

ryanoasis/nerd-fonts#1527

by @Gaspartcho

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@hasecilu
Copy link
Collaborator

hasecilu commented Mar 8, 2024

Actually I wanted to also include LibreOffice specific icons here but since they a little complex I decided to not do it and use the generic office icons for this PR: eza-community/eza#565

@Gaspartcho, do you planned other use case apart from terminal? At least we can try to see how would be use them for LibreOffice files, they are very cool indeed.

@Gaspartcho
Copy link

The reason I initially wanted to put these icons was that the text editor I use used the icons from NerdFonts in order to show file icons in the treeview

@hasecilu
Copy link
Collaborator

hasecilu commented Mar 10, 2024

I made a test and this is how it would look like with some different sizes with eza
image
vs
image

Here is the font if you want to test for your use case:

Icon Position
LibreOffice 0xf373
LibreOffice Base 0xf374
LibreOffice Calc 0xf375
LibreOffice Draw 0xf376
LibreOffice Impress 0xf377
LibreOffice Math 0xf378

SymbolsNerdFont-Regular.ttf.zip

@Finii
Copy link
Collaborator Author

Finii commented Mar 10, 2024

My opinion...

The small details that make the icons different are a bit ... small. And hard to discern.
Of course we could enlarge that details.

Otoh I really hate these Microsoft centric icons with p and x 😒

Edit: Also that odf and odg have no file-border while the odp odt ods have is strange.

@hasecilu
Copy link
Collaborator

Of course we could enlarge that details.

Could be useful to make another test

Otoh I really hate these Microsoft centric icons with p and x 😒

Me too.

Edit: Also that odf and odg have no file-border while the odp odt ods have is strange.

The odg is the generic vector icon and odf just sqrt(2), since those extensions are specific to OpenDocument format the LibreOffice icons can be a good fit.

@Finii
Copy link
Collaborator Author

Finii commented Mar 13, 2024

image

Hmm, seeing them irl here, they do not look as bad as expected.

@hasecilu
Copy link
Collaborator

hasecilu commented Apr 5, 2024

I made a test enlarging the writer logo, I think that size is good, details are more easily recognizable. See f.odt2 file icon.

I took file from /usr/share/icons/hicolor/scalable I have LibreOffice 24.2.2-2
image

image

@Finii
Copy link
Collaborator Author

Finii commented Apr 5, 2024

Nice idea 👍

But you change the content itself instead of just scaling up. I'm not sure that it is then still 'the same logo'.
Here a quick n dirty Gimp manipulation with just scaling up the text-and-image thing without further modification.

image

@hasecilu
Copy link
Collaborator

hasecilu commented Apr 5, 2024

The old icons already have 2 years from last update on help module: https://github.com/LibreOffice/help/tree/master/source/media/navigation which is the source from simple-icons

The new ones are here, also from 2 years ago but have these modern, rounded design in core package: https://github.com/LibreOffice/core/tree/3ca12a07335e1e9ae6b64491faaab6a46e9c4db5/sysui/desktop/icons/hicolor/scalable/apps

Branding page: https://wiki.documentfoundation.org/Design/Branding

See difference:

Edit: Testing branch -> https://github.com/hasecilu/font-logos/tree/test/libreoffice

Previous icons are not rounded but their elements are slightly bigger.
image

@hasecilu
Copy link
Collaborator

This is a comparative of different small sizes with the both group of icons.

The first pack of logos are the older ones at original scale, the second pack contains the newer logos with an increase in the central glyphs to make it more differentiable at small scales (as would be expected on most terminal emulators).

In the first pack the glyphs are well centered, in the second pack seems to be a more like in the bottom because of the top corner cut.

image

@Finii
Copy link
Collaborator Author

Finii commented May 29, 2024

Excellent.
I went through their icons and you are right they changed them a bit.

I believe they (your modified icons) look very good.

Just some comment (of course 😉 )

image

  • The blank file black block has more room in the bottom than in the top, maybe move down 'a pixel'
    Even with small sizes I noticed that immediately.
  • And I like the distance between symbol and border for draw (square, triangle, circle) better than the other icons where the symbol feels more down. Yes the other symbols are taller, but maybe we can nudge them a bit up. I guess they will not yet collide with the folded corner thing. Esp 'math' and 'database' (?) seem very low and still the is space in the top.

Nice work! 👍

Edit: Add this image from 'afar':

image

@Finii
Copy link
Collaborator Author

Finii commented May 29, 2024

I guess you should just cherry pick your commits into this branch. After tweaking if you like. 🐱
Then we have later on this discussion linked with the commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants