Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse Swagger (x-)examples and store in Internal #152

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Parse Swagger (x-)examples and store in Internal #152

wants to merge 1 commit into from

Conversation

philsturgeon
Copy link

@philsturgeon philsturgeon commented Dec 7, 2017 •
edited

Support both example: foo and x-example: foo, as x-example is a common vendor extension used for Dredd.

@philsturgeon philsturgeon force-pushed the feature/swagger-examples branch 4 times, most recently from f099115 to 891bbf1 Compare December 11, 2017 22:18
@philsturgeon philsturgeon changed the title WIP Parse Swagger (x-)examples and store in Internal Parse Swagger (x-)examples and store in Internal Dec 11, 2017
philsturgeon
philsturgeon commented Dec 11, 2017
View reviewed changes
src/parsers/swagger/v2.0/Parser.js Outdated
@@ -1252,6 +1252,12 @@ methods.convertParameterObjectIntoParameter = (parameterEntry) => {
applicableContexts
}

if (parameter.example) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If both for any weird reason then only bother using the first.

@philsturgeon philsturgeon force-pushed the feature/swagger-examples branch 3 times, most recently from 3d1cae9 to 92d34c3 Compare December 12, 2017 01:44
mittsh
mittsh approved these changes Dec 22, 2017
View reviewed changes
Copy link
Contributor

@mittsh mittsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@philsturgeon
Copy link
Author

Awesome! Could you merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mittsh mittsh mittsh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@philsturgeon @mittsh