Support URL Objects #145
Open
Support URL Objects #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added link to documentation in README
Fixed Path Bugs in Paw Parser
added support for custom headers for api key auths
fixed pathname bug for very weird urls
…nfigs fixed missing postman loader, parser, and serializers from configs
loaders now defaults to fsResolution instead of httpResolution
Still not entirely working but its closer
Fix postman for node
philsturgeon
force-pushed
the
bug/case-of-the-missing-urls
branch
from
328294b
to
059bab0
Compare
The README talked a bit too much about Paw, which is not what this library is going to be used for by the community at large. It also focused on compile instructions over recommending npm/yarn installation. ALSO the compile instructions were invalid, and talked about make install (doesnt exist!).
Linked to issues where they exist, and removed CLI usage (as it does not exist).
A few forks were updating these links and causing conflicts, so lets just use local links :D
…o JonathanMontane-fork
Empty string is valid, null is invalid.
philsturgeon
force-pushed
the
bug/case-of-the-missing-urls
branch
from
059bab0
to
a471ed7
Compare
philsturgeon
changed the title
|
Done! Ready! Merge me :D |
philsturgeon
force-pushed
the
bug/case-of-the-missing-urls
branch
from
a471ed7
to
1827712
Compare
URL objects with raw but not a lot else were causing empty URLs, which shoved everything into / instead of gracefully figuring it out. Now if a URL is an object with "raw" it'll use the raw string.
philsturgeon
force-pushed
the
bug/case-of-the-missing-urls
branch
2 times, most recently
from
b415b9b
to
655b752
Compare
philsturgeon
changed the title
|
This has a bunch of extra commits, and I'll tidy them once somebody has started merging some of my bajillion open unanswered PRs. For now the megabranch will continue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the day job we're programmatically converting postman files found in various repos into OpenAPI. I can advise the teams to improve their Postman collections, but do not have direct control over them, and need the ability to repeatedly convert these collections, with only increasing quality. :)
We have some hand-made collections where the output is URLs all showing the root path
/.That has some further weird knock-on effects:
The issue seems to happen if there are some missing properties in the Postman URL Object, but if 'raw' is present why not just use that.
The main commit here is 655b752, but there's a bunch of other changes floating around. Please merge some of the other PRs I've made and it'll start to look less messy around here :D