Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please dont make contributors hunt for instructions #144

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

philsturgeon
Copy link

@philsturgeon philsturgeon commented Nov 30, 2017

Nice easy tips for contributors getting started, who might not know where to look otherwise.

@fenollp
Copy link

fenollp commented Nov 30, 2017

FWIW to me .travis,yml is the first place to look at when trying to understand how to build & test a project, given that

  • it's its purpose
  • it usually works
  • there is usually not much to read there

What is the first place you look at? I'm interested as I should probably update some of my projects accordingly

@philsturgeon
Copy link
Author

That's cool if you've heard of Travis and know think to look at the config file. 👍🏼

If they switch away from Travis to some other thing are you gonna know where that config file lives too?

README.md Outdated
@@ -91,10 +91,12 @@ API-Flow is one of the main components of [Console.REST](https://github.com/luck

## Contributing

PRs are welcomed!
Read [CONTRIBUTING.md][] for more tips on testing and contributing.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding a link here, @philsturgeon?

Or is this equivalent with [CONTRIBUTING.md](CONTRIBUTING.md)?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed! Thanks, I was using some random syntax that clearly isn't GFM

@@ -91,10 +91,12 @@ API-Flow is one of the main components of [Console.REST](https://github.com/luck

## Contributing

PRs are welcomed!
Read [CONTRIBUTING.md](CONTRIBUTING.md) for more tips on testing and contributing.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@localheinz
Copy link

@philsturgeon philsturgeon force-pushed the please-dont-make-contributors-hunt branch 2 times, most recently from e9995f8 to 0cca354 Compare December 5, 2017 18:14
Phil Sturgeon added 2 commits December 5, 2017 13:15
A few forks were updating these links and causing conflicts, so lets just use local links :D
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants